Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect rest response header and demo double path error #13789

Conversation

suncairong163
Copy link
Contributor

@suncairong163 suncairong163 commented Feb 25, 2024

What is the purpose of the change

fix #13640
#13665

Brief changelog

Verifying this change

@AlbumenJ

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.34%. Comparing base (99613a1) to head (11bff8a).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13789      +/-   ##
==========================================
+ Coverage   70.32%   70.34%   +0.01%     
==========================================
  Files        1606     1606              
  Lines       70022    70030       +8     
  Branches    10102    10106       +4     
==========================================
+ Hits        49246    49263      +17     
+ Misses      16141    16128      -13     
- Partials     4635     4639       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@CrazyHZM PTAL

public class JsonCodec implements HttpMessageCodec<byte[], OutputStream> {
private static final Set<Class> unSupportClasses = new HashSet<>();

static {
unSupportClasses.add(byte[].class);
unSupportClasses.add(String.class);
// unSupportClasses.add(String.class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove it.

@CrazyHZM CrazyHZM changed the title fix dubbo demo xml double path error Fix incorrect rest response header and demo double path error Feb 26, 2024
Copy link

sonarcloud bot commented Feb 27, 2024

@CrazyHZM CrazyHZM added this to the 3.2.12 milestone Feb 28, 2024
@CrazyHZM CrazyHZM merged commit 69dd801 into apache:3.2 Feb 28, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dubbo-demo-xml-provider error:dubbo rest metadata resolve double path error,and do not contain path variable
4 participants