-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect rest response header and demo double path error #13789
Fix incorrect rest response header and demo double path error #13789
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13789 +/- ##
==========================================
+ Coverage 70.32% 70.34% +0.01%
==========================================
Files 1606 1606
Lines 70022 70030 +8
Branches 10102 10106 +4
==========================================
+ Hits 49246 49263 +17
+ Misses 16141 16128 -13
- Partials 4635 4639 +4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@CrazyHZM PTAL
public class JsonCodec implements HttpMessageCodec<byte[], OutputStream> { | ||
private static final Set<Class> unSupportClasses = new HashSet<>(); | ||
|
||
static { | ||
unSupportClasses.add(byte[].class); | ||
unSupportClasses.add(String.class); | ||
// unSupportClasses.add(String.class); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it.
|
What is the purpose of the change
fix #13640
#13665
Brief changelog
Verifying this change
@AlbumenJ
Checklist