Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lazy property of serviceBeanDefinition to false #13787

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Conversation

laywin
Copy link
Contributor

@laywin laywin commented Feb 23, 2024

What is the purpose of the change

fix #13758

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@laywin
Copy link
Contributor Author

laywin commented Feb 23, 2024

@AlbumenJ PTAL

Copy link

sonarcloud bot commented Feb 23, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.35%. Comparing base (99613a1) to head (58ac606).

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13787      +/-   ##
==========================================
+ Coverage   70.32%   70.35%   +0.02%     
==========================================
  Files        1606     1606              
  Lines       70022    70023       +1     
  Branches    10102    10102              
==========================================
+ Hits        49246    49264      +18     
+ Misses      16141    16120      -21     
- Partials     4635     4639       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member

Please add a integration test case to verify it

laywin added a commit to laywin/dubbo-integration-cases that referenced this pull request Feb 26, 2024
@AlbumenJ AlbumenJ merged commit d53d8e5 into apache:3.2 Feb 29, 2024
19 checks passed
AlbumenJ added a commit to apache/dubbo-integration-cases that referenced this pull request Mar 11, 2024
* add integration test case to verify apache/dubbo#13787

* Update 99-integration/dubbo-samples-test-13787/pom.xml

modify dubbo version

Co-authored-by: Albumen Kevin <jhq0812@gmail.com>

---------

Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants