Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rest): Fix rest convert error #13783

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Feb 23, 2024

What is the purpose of the change

Fix initialization failure when jaxrs jar is missing due to use of convert.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Feb 23, 2024

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.64%. Comparing base (46af145) to head (e4d86fb).
Report is 67 commits behind head on 3.3.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13783      +/-   ##
==========================================
- Coverage   41.41%   38.64%   -2.77%     
==========================================
  Files        1750     1894     +144     
  Lines       73370    79244    +5874     
  Branches    10371    11529    +1158     
==========================================
+ Hits        30388    30627     +239     
- Misses      38691    44313    +5622     
- Partials     4291     4304      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 044a775 into apache:3.3 Feb 26, 2024
19 checks passed
@oxsean oxsean deleted the fix-rest-convert-error branch July 23, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants