Fix ModuleEnvironment#getDynamicGlobalConfiguration #13781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13781 +/- ##
==========================================
+ Coverage 70.32% 70.38% +0.05%
==========================================
Files 1606 1606
Lines 70022 70020 -2
Branches 10102 10101 -1
==========================================
+ Hits 49246 49286 +40
+ Misses 16141 16096 -45
- Partials 4635 4638 +3 ☔ View full report in Codecov by Sentry. |
|
@AlbumenJ PTAL |
AlbumenJ
requested changes
Feb 23, 2024
dubbo-common/src/main/java/org/apache/dubbo/common/config/ModuleEnvironment.java
Outdated
Show resolved
Hide resolved
JoeCqupt
commented
Feb 23, 2024
| if (dynamicGlobalConfiguration == null) { | ||
| if (dynamicConfiguration == null) { |
There was a problem hiding this comment.
This situation has already been handled, here is unnecessary code
JoeCqupt
commented
Feb 23, 2024
| @@ -94,19 +92,13 @@ public List<Map<String, String>> getConfigurationMaps(AbstractConfig config, Str | |||
| @Override | |||
| public Configuration getDynamicGlobalConfiguration() { | |||
| if (dynamicConfiguration == null) { | |||
| return applicationDelegate.getDynamicGlobalConfiguration(); | |||
| CompositeConfiguration configuration = new CompositeConfiguration(); | |||
There was a problem hiding this comment.
Composite application dynamic configuration and module ordered properties configuration
|
|
@AlbumenJ PTAL |
JoeCqupt
changed the title
JoeCqupt
changed the title
AlbumenJ
approved these changes
Feb 28, 2024
CrazyHZM
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fix ModuleEnvironment#getDynamicGlobalConfiguration ignore OrderedPropertiesConfiguration when
dynamicConfigurationis nullfix issue: #13782
Brief changelog
Fix ModuleEnvironment#getDynamicGlobalConfiguration
Verifying this change
Checklist