-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh valid invokers after connectivity check #13773
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5179991
Refresh valid invokers after connectivity check
AlbumenJ 696b7a9
Add lock
AlbumenJ db1373b
Add lock
AlbumenJ 87574c5
style
AlbumenJ a49631b
Add log
AlbumenJ 83bdea5
Add log
AlbumenJ f860b3a
Enhance code
AlbumenJ 219376f
Add test
AlbumenJ File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
dubbo-common/src/main/java/org/apache/dubbo/common/utils/LockUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package org.apache.dubbo.common.utils; | ||
|
||
import org.apache.dubbo.common.constants.LoggerCodeConstants; | ||
import org.apache.dubbo.common.logger.ErrorTypeAwareLogger; | ||
import org.apache.dubbo.common.logger.LoggerFactory; | ||
|
||
import java.util.concurrent.TimeUnit; | ||
import java.util.concurrent.TimeoutException; | ||
import java.util.concurrent.locks.Lock; | ||
|
||
public class LockUtils { | ||
private static final ErrorTypeAwareLogger logger = LoggerFactory.getErrorTypeAwareLogger(LockUtils.class); | ||
|
||
public static final int DEFAULT_TIMEOUT = 60_000; | ||
|
||
public static void safeLock(Lock lock, int timeout, Runnable runnable) { | ||
try { | ||
if (!lock.tryLock(timeout, TimeUnit.MILLISECONDS)) { | ||
logger.error( | ||
LoggerCodeConstants.INTERNAL_ERROR, | ||
"", | ||
"", | ||
"Try to lock failed, timeout: " + timeout, | ||
new TimeoutException()); | ||
} | ||
runnable.run(); | ||
} catch (InterruptedException e) { | ||
logger.warn(LoggerCodeConstants.INTERNAL_ERROR, "", "", "Try to lock failed", e); | ||
Thread.currentThread().interrupt(); | ||
} finally { | ||
try { | ||
lock.unlock(); | ||
} catch (Exception e) { | ||
// ignore | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed there are three separate code snippets in this method that are protected with locks. Would a single method-level lock do the trick?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To prevent lock
isAvailable()