Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#13305): RpcContext local address info get null on custom filter #13751

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

aofall
Copy link
Contributor

@aofall aofall commented Feb 7, 2024

What is the purpose of the change

fix #13305 RpcContext local address info get null on custom filter

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6eddf7) 70.34% compared to head (76fa709) 70.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13751      +/-   ##
==========================================
+ Coverage   70.34%   70.37%   +0.02%     
==========================================
  Files        1606     1606              
  Lines       70022    70021       -1     
  Branches    10103    10103              
==========================================
+ Hits        49255    49274      +19     
+ Misses      16126    16120       -6     
+ Partials     4641     4627      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member

Please add a integration test case to verify it in https://github.com/apache/dubbo-integration-cases

@AlbumenJ AlbumenJ merged commit 36e0cf5 into apache:3.2 Mar 11, 2024
19 checks passed
AlbumenJ added a commit to apache/dubbo-integration-cases that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RpcContext.getServiceContext().getLocalAddressString() return zero port on consumer side !
3 participants