Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix port unification issue in triple and dubbo protocol #13696

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Fix port unification issue in triple and dubbo protocol #13696

merged 4 commits into from
Jan 31, 2024

Conversation

namelessssssssssss
Copy link
Contributor

@namelessssssssssss
Copy link
Contributor Author

@AlbumenJ PTAL

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 28, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
11.1% Coverage on New Code
8.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5c0b1de) 70.34% compared to head (85280d8) 70.31%.

Additional details and impacted files 
@@            Coverage Diff             @@
##              3.2   #13696      +/-   ##
==========================================
- Coverage   70.34%   70.31%   -0.03%     
==========================================
  Files        1606     1606              
  Lines       70032    70033       +1     
  Branches    10104    10104              
==========================================
- Hits        49261    49245      -16     
- Misses      16135    16153      +18     
+ Partials     4636     4635       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AlbumenJ
AlbumenJ approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ
Copy link
Member

@EarthChen PTAL

EarthChen
EarthChen approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 29b0c72 into apache:3.2 Jan 31, 2024
19 checks passed
Will-well pushed a commit to Will-well/dubbo that referenced this pull request Jan 31, 2024
@namelessssssssssss @Will-well
Fix port unification issue in triple and dubbo protocol (apache#13696)
75053f1 
* Fix issue of tri Portunification

* style fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlbumenJ AlbumenJ AlbumenJ approved these changes

@EarthChen EarthChen EarthChen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dubbo 3.2.1协议端口复用，consumer端报错
4 participants
@namelessssssssssss @codecov-commenter @AlbumenJ @EarthChen