Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not invoke test method(#13589) #13601

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

vio-lin
Copy link
Contributor

@vio-lin vio-lin commented Jan 3, 2024

What is the purpose of the change

there is a test method but execute by org.apache.dubbo.common.extension.ExtensionLoader#injectExtension

org.apache.dubbo.rpc.filter.ExceptionFilter#setLogger

image

Brief changelog

ignore test method when extensionLoader inject instance.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • [x ] Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

image

Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50c5a66) 70.37% compared to head (df26a03) 70.38%.
Report is 14 commits behind head on 3.2.

Additional details and impacted files
@@           Coverage Diff           @@
##              3.2   #13601   +/-   ##
=======================================
  Coverage   70.37%   70.38%           
=======================================
  Files        1606     1606           
  Lines       69988    70001   +13     
  Branches    10097    10099    +2     
=======================================
+ Hits        49256    49270   +14     
- Misses      16095    16104    +9     
+ Partials     4637     4627   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 966efaa into apache:3.2 Jan 10, 2024
18 checks passed
Will-well pushed a commit to Will-well/dubbo that referenced this pull request Jan 31, 2024
* do not invoke test method(apache#13589)

* Fix style check

---------

Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
vio-lin added a commit to vio-lin/incubator-dubbo that referenced this pull request Jul 11, 2024
* do not invoke test method(apache#13589)

* Fix style check

---------

Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
vio-lin added a commit to vio-lin/incubator-dubbo that referenced this pull request Jul 31, 2024
* do not invoke test method(apache#13589)

* Fix style check

---------

Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
vio-lin added a commit to vio-lin/incubator-dubbo that referenced this pull request Jul 31, 2024
do not invoke test method(apache#13589) (apache#13601)

See merge request framework/dubbo!76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants