Fix MergeableClusterInvoker log issue #13593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
namelessssssssssss
commented
Jan 1, 2024
•
namelessssssssssss
commented
- fix MergeableClusterInvoker can fail to log unavailable providers #12614
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13593 +/- ##
==========================================
- Coverage 70.37% 70.36% -0.02%
==========================================
Files 1606 1606
Lines 69988 69997 +9
Branches 10097 10098 +1
==========================================
- Hits 49256 49251 -5
- Misses 16095 16117 +22
+ Partials 4637 4629 -8 ☔ View full report in Codecov by Sentry. |
AlbumenJ
requested changes
Jan 2, 2024
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/MergeableClusterInvoker.java
Outdated
Show resolved
Hide resolved
CrazyHZM
approved these changes
Jan 2, 2024
|
|
CrazyHZM
requested changes
Jan 2, 2024
Comment on lines
105
to
106
| "No available provider for service" + getUrl().getServiceKey() + " on group " | ||
| + invoker.getUrl().getGroup() + ", will continue to try another group."); |
There was a problem hiding this comment.
Add the exception stack as well.
@namelessssssssssss
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.