-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix MergeableClusterInvoker log issue #13593
Fix MergeableClusterInvoker log issue #13593
Conversation
namelessssssssssss
commented
Jan 1, 2024
•
edited
Loading
edited
- fix MergeableClusterInvoker can fail to log unavailable providers #12614
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13593 +/- ##
==========================================
- Coverage 70.37% 70.36% -0.02%
==========================================
Files 1606 1606
Lines 69988 69997 +9
Branches 10097 10098 +1
==========================================
- Hits 49256 49251 -5
- Misses 16095 16117 +22
+ Partials 4637 4629 -8 ☔ View full report in Codecov by Sentry. |
dubbo-cluster/src/main/java/org/apache/dubbo/rpc/cluster/support/MergeableClusterInvoker.java
Outdated
Show resolved
Hide resolved
"No available provider for service" + getUrl().getServiceKey() + " on group " | ||
+ invoker.getUrl().getGroup() + ", will continue to try another group."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add the exception stack as well.
@namelessssssssssss
|