Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MethodKeyRt override & Error enhance #13580

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

  • Fix java.lang.ArithmeticException
  • Error enhance when calc metrics

Brief changelog

 THROW-EXCEPTION  java.lang.ArithmeticException: / by zero
                    at org.apache.dubbo.metrics.data.RtStatComposite.lambda$initStats$19(RtStatComposite.java:90)
                    at org.apache.dubbo.metrics.data.RtStatComposite.lambda$export$20(RtStatComposite.java:204)
                    at io.micrometer.core.instrument.internal.DefaultGauge.value(DefaultGauge.java:40)
                    at io.micrometer.prometheus.PrometheusMeterRegistry.lambda$newGauge$3(PrometheusMeterRegistry.java:230)
                    at io.micrometer.prometheus.MicrometerCollector.lambda$collect$0(MicrometerCollector.java:81)

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member Author

@songxiaosheng PTAL

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1368e21) 70.40% compared to head (f80d2d0) 70.37%.
Report is 1 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13580      +/-   ##
==========================================
- Coverage   70.40%   70.37%   -0.03%     
==========================================
  Files        1605     1605              
  Lines       69964    69972       +8     
  Branches    10092    10095       +3     
==========================================
- Hits        49255    49246       -9     
- Misses      16075    16096      +21     
+ Partials     4634     4630       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AlbumenJ added a commit to AlbumenJ/dubbo-integration-cases that referenced this pull request Dec 27, 2023
@AlbumenJ
Copy link
Member Author

Integration test cases apache/dubbo-integration-cases#4

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Dec 27, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlbumenJ AlbumenJ merged commit 745ba45 into apache:3.2 Dec 27, 2023
18 checks passed
@AlbumenJ AlbumenJ added this to the 3.2.11 milestone Dec 27, 2023
AlbumenJ added a commit to apache/dubbo-integration-cases that referenced this pull request Mar 11, 2024
* Add test cases to verify apache/dubbo#13580

* Fix license

* Update version

* Enhance case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants