-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix proto package
and java_package
issue
#13559
Fix proto package
and java_package
issue
#13559
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13559 +/- ##
==========================================
- Coverage 70.39% 70.37% -0.02%
==========================================
Files 1604 1604
Lines 69957 69964 +7
Branches 10093 10095 +2
==========================================
- Hits 49246 49240 -6
- Misses 16082 16092 +10
- Partials 4629 4632 +3 ☔ View full report in Codecov by Sentry. |
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Outdated
Show resolved
Hide resolved
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix issue #13496
useJavaPackageAsPath
useJavaPackageAsPath=ture
: Provider will export with java_package as path, which will cause exception whenpackage
andjava_package
are different.useJavaPackageAsPath=false
(default) : Provider will export with package as path.