Fix proto package and java_package issue
#13559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13559 +/- ##
==========================================
- Coverage 70.39% 70.37% -0.02%
==========================================
Files 1604 1604
Lines 69957 69964 +7
Branches 10093 10095 +2
==========================================
- Hits 49246 49240 -6
- Misses 16082 16092 +10
- Partials 4629 4632 +3 ☔ View full report in Codecov by Sentry. |
EarthChen
reviewed
Dec 25, 2023
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/ServiceConfig.java
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #13496
useJavaPackageAsPathuseJavaPackageAsPath=ture: Provider will export with java_package as path, which will cause exception whenpackageandjava_packageare different.useJavaPackageAsPath=false(default) : Provider will export with package as path.