Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize isProtobufClass method impl #13557

Merged
merged 3 commits into from
Dec 26, 2023
Merged

optimize isProtobufClass method impl #13557

merged 3 commits into from
Dec 26, 2023

Conversation

SpringStudent
Copy link
Contributor

What is the purpose of the change

The isProtobufClass method is extracted as a tool class, and the implementation is optimized.

Brief changelog

optimize isProtobufClass method impl

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

image

Copy link

sonarcloud bot commented Dec 25, 2023

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7a32be) 70.34% compared to head (c0bb406) 70.41%.
Report is 18 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13557      +/-   ##
==========================================
+ Coverage   70.34%   70.41%   +0.06%     
==========================================
  Files        1603     1605       +2     
  Lines       69886    69957      +71     
  Branches    10092    10090       -2     
==========================================
+ Hits        49161    49257      +96     
+ Misses      16096    16073      -23     
+ Partials     4629     4627       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 1368e21 into apache:3.2 Dec 26, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants