-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:DubboService annotation support custom serialization #13553
feat:DubboService annotation support custom serialization #13553
Conversation
config.getScopeModel(), | ||
Serialization.class, | ||
PREFER_SERIALIZATION_KEY, | ||
config.getPreferSerialization()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value of prefer.serialization
should be splitted first cause it can be fastjson2,hessian2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ConfigValidationUtils.java#L695 value has been splitted
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.2 #13553 +/- ##
==========================================
+ Coverage 70.35% 70.38% +0.03%
==========================================
Files 1603 1605 +2
Lines 69886 69970 +84
Branches 10092 10092
==========================================
+ Hits 49165 49247 +82
+ Misses 16096 16087 -9
- Partials 4625 4636 +11 ☔ View full report in Codecov by Sentry. |
dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/AbstractConfigTest.java
Show resolved
Hide resolved
|
What is the purpose of the change
fix: #13552
Brief changelog
Verifying this change
Checklist