Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix native demo logback dependency #13551

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ff2bdd0) 70.35% compared to head (8a1dac9) 70.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13551      +/-   ##
==========================================
+ Coverage   70.35%   70.36%   +0.01%     
==========================================
  Files        1603     1603              
  Lines       69886    69886              
  Branches    10092    10092              
==========================================
+ Hits        49170    49177       +7     
+ Misses      16080    16079       -1     
+ Partials     4636     4630       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyHZM CrazyHZM merged commit cb8d7a3 into apache:3.2 Dec 21, 2023
18 checks passed
@CrazyHZM CrazyHZM deleted the fix/demo_native branch December 21, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants