Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix complete already #13546

Merged
merged 2 commits into from
Dec 25, 2023
Merged

fix complete already #13546

merged 2 commits into from
Dec 25, 2023

Conversation

icodening
Copy link
Contributor

What is the purpose of the change

fix #13398

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@AlbumenJ
Copy link
Member

image

Is this failure related with this PR?

Copy link

sonarcloud bot commented Dec 23, 2023

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (24c6a52) 70.38% compared to head (b30247d) 70.35%.
Report is 16 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.2   #13546      +/-   ##
==========================================
- Coverage   70.38%   70.35%   -0.03%     
==========================================
  Files        1602     1603       +1     
  Lines       69873    69887      +14     
  Branches    10090    10093       +3     
==========================================
- Hits        49178    49167      -11     
- Misses      16074    16087      +13     
- Partials     4621     4633      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ
Copy link
Member

@EarthChen PTAL

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit e26a22d into apache:3.2 Dec 25, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

complete already: DefaultPromise
5 participants