Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtocolBuilder add sslEnabled and extProtocol fields #13515

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

manzhizhen
Copy link

@manzhizhen manzhizhen commented Dec 17, 2023

What is the purpose of the change

ProtocolBuilder add sslEnabled and extProtocol fields, aligned with ProtocolConfig.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Dec 17, 2023

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43e513d) 69.59% compared to head (6b31172) 70.36%.
Report is 60 commits behind head on 3.2.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13515      +/-   ##
============================================
+ Coverage     69.59%   70.36%   +0.76%     
============================================
  Files          1653     1602      -51     
  Lines         71623    69879    -1744     
  Branches      10269    10090     -179     
============================================
- Hits          49847    49169     -678     
+ Misses        17083    16081    -1002     
+ Partials       4693     4629      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit d685ff2 into apache:3.2 Dec 20, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants