Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only call DubboBootstrap.reset(); once to make the test faster #13466

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

TestBoost
Copy link
Contributor

@TestBoost TestBoost commented Dec 9, 2023

What is the purpose of the change

The propose of this change is to make tests run faster. DubboBootstrap is only used once in the test org.apache.dubbo.generic.GenericServiceTest. There are five tests in the test class org.apache.dubbo.generic.GenericServiceTest. However, only testGenericCompatible tries to modify with DubboBootstrap and other four tests are not dealing with DubboBootstrap. Repeatly calling DubboBootstrap.reset(); may cause a big cost in time. On our local machine, the time can jump from 4.281 s to 1.429 s after applying the change.

Brief changelog

Change the @BeforeEach annotation to @AfterEach annotation to only call DubboBootstrap.reset(); once.

Verifying this change

We confirm that if make this change, the test run time can jump from 4.281 s to 1.429 s.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Dec 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5554706) 69.47% compared to head (f4ff788) 69.46%.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13466      +/-   ##
============================================
- Coverage     69.47%   69.46%   -0.01%     
  Complexity        2        2              
============================================
  Files          1655     1655              
  Lines         71701    71701              
  Branches      10278    10278              
============================================
- Hits          49812    49810       -2     
- Misses        17174    17182       +8     
+ Partials       4715     4709       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TestBoost TestBoost marked this pull request as ready for review December 10, 2023 05:16
@AlbumenJ AlbumenJ merged commit 570cd47 into apache:3.2 Dec 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants