only call DubboBootstrap.reset(); once to make the test faster #13466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The propose of this change is to make tests run faster.
DubboBootstrap
is only used once in the testorg.apache.dubbo.generic.GenericServiceTest
. There are five tests in the test classorg.apache.dubbo.generic.GenericServiceTest
. However, onlytestGenericCompatible
tries to modify withDubboBootstrap
and other four tests are not dealing withDubboBootstrap
. Repeatly callingDubboBootstrap.reset();
may cause a big cost in time. On our local machine, the time can jump from 4.281 s to 1.429 s after applying the change.Brief changelog
Change the
@BeforeEach
annotation to@AfterEach
annotation to only callDubboBootstrap.reset();
once.Verifying this change
We confirm that if make this change, the test run time can jump from
4.281 s
to1.429 s
.Checklist