-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 fix metrics servce level config bug #13449
Merged
AlbumenJ
merged 5 commits into
apache:3.2
from
songxiaosheng:fix_service_metrics_in_rt_stat
Dec 4, 2023
Merged
🐛 fix metrics servce level config bug #13449
AlbumenJ
merged 5 commits into
apache:3.2
from
songxiaosheng:fix_service_metrics_in_rt_stat
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlbumenJ
requested changes
Dec 1, 2023
|
||
private void initServiceLevelConfig() { | ||
if (serviceLevel == null) { | ||
synchronized (AbstractMetricsExport.class) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lock current object is enough
import org.apache.dubbo.rpc.model.ApplicationModel; | ||
|
||
/** | ||
* Store public information such as application | ||
*/ | ||
public abstract class AbstractMetricsExport implements MetricsExport { | ||
|
||
private Boolean serviceLevel; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add volatile
Kudos, SonarCloud Quality Gate passed! |
@AlbumenJ PATL |
AlbumenJ
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
servce level config is init after application config be load
test result is such as:
![image](https://private-user-images.githubusercontent.com/81170548/287259467-530a4795-172a-4a31-ba65-554c7c259a42.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTg1ODIsIm5iZiI6MTcyNDI5ODI4MiwicGF0aCI6Ii84MTE3MDU0OC8yODcyNTk0NjctNTMwYTQ3OTUtMTcyYS00YTMxLWJhNjUtNTU0YzdjMjU5YTQyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDAzNDQ0MlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZhM2I0OGQ0ZDQyOTRjOTgyNzc5NWY5ZjkxMWJkZWYwZjU2MmE1NTBhOTg4MTg0MTRkNTg4MDVlYmFjZWZkNDQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.0HRFmaO-YS6Q24oAfjEmOIPKF7kxraOeeRAliWTb4MQ)
Brief changelog
Verifying this change
Checklist