Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify main class configuration,fix native image build error when mainClass not set #13426

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

FoghostCn
Copy link
Contributor

@FoghostCn FoghostCn commented Nov 27, 2023

fix native image build error when mainClass is not set

What is the purpose of the change

resolve #13365

mainClass config is not used in dubbo-maven-plugin and dubbo-native module,but if not set it will cause wrong arguments index for generate Aot Assets, so add an empty string as a placeholder when mainClass is not set to prevent build error

now if mainClass is not set, native image can also build success

<plugin>
    <groupId>org.apache.dubbo</groupId>
    <artifactId>dubbo-maven-plugin</artifactId>
    <version>${dubbo.version}</version>
    <executions>
        <execution>
            <phase>process-sources</phase>
            <goals>
                <goal>dubbo-process-aot</goal>
            </goals>
        </execution>
    </executions>
</plugin>

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@FoghostCn FoghostCn changed the title fix native image build error when mainClass is not set simplify main class configuration,fix native image build error when mainClass not set Nov 27, 2023
Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a53228d) 40.40% compared to head (c3d993a) 40.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13426      +/-   ##
==========================================
+ Coverage   40.40%   40.42%   +0.01%     
==========================================
  Files        1807     1807              
  Lines       75867    75867              
  Branches    10642    10643       +1     
==========================================
+ Hits        30657    30669      +12     
+ Misses      40911    40891      -20     
- Partials     4299     4307       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CrazyHZM CrazyHZM merged commit 7e0954b into apache:3.3 Nov 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants