Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(logging): #13378 Uniformly uses log4j2 as the logging component #13402

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Nov 21, 2023

What is the purpose of the change

Currently in Dubbo, there is a mixed use of log components, and some modules lack log configuration, due to no log output. Therefore, uniformly use log4j2 can reduce the learning and cost, reduce logging component conflicts

Brief changelog

  1. Replace log4j and logback with log4j2, providing a simple Log4j2 configuration. Unfortunately log4j2 does not support native, so have to use logback, update future while log4j2 support native.

  2. Adjusted versions of some artifacts in pom.xml to unify them as much as possible to the BOM.

Verifying this change

ci passed

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit a53228d into apache:3.3 Nov 22, 2023
14 checks passed
@oxsean oxsean deleted the feature-13378-uniformly-use-log4j2 branch November 23, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants