Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.micrometer:micrometer-tracing-bom from 1.1.6 to 1.2.0 #13397

Merged
merged 1 commit into from
Nov 25, 2023

Conversation

conghuhu
Copy link
Contributor

@conghuhu conghuhu commented Nov 21, 2023

What is the purpose of the change

fix & close #13393

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@conghuhu conghuhu force-pushed the fix-micrometer-tracing-version branch 2 times, most recently from 1dfcdbc to bfab0a0 Compare November 21, 2023 02:46
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (883195a) 69.51% compared to head (af121ee) 69.49%.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13397      +/-   ##
============================================
- Coverage     69.51%   69.49%   -0.02%     
  Complexity        2        2              
============================================
  Files          1653     1653              
  Lines         71621    71634      +13     
  Branches      10268    10270       +2     
============================================
- Hits          49785    49780       -5     
- Misses        17137    17147      +10     
- Partials       4699     4707       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you considering compatibility between two versions through the existence of classes?

@conghuhu conghuhu force-pushed the fix-micrometer-tracing-version branch from bfab0a0 to f77ac24 Compare November 21, 2023 13:39
@conghuhu
Copy link
Contributor Author

Are you considering compatibility between two versions through the existence of classes?

@songxiaosheng Thank you for your suggestion. The code has been updated

chore: compatibility between two versions through the existence of classes
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conghuhu conghuhu merged commit e63d275 into apache:3.2 Nov 25, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants