-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support more content types for Triple protocol #13387
Support more content types for Triple protocol #13387
Conversation
… 3.3-triple-multipart-codec # Conflicts: # dubbo-rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/h12/AbstractServerTransportListener.java
...-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/message/codec/CodecUtil.java
Outdated
Show resolved
Hide resolved
...ting-http12/src/main/java/org/apache/dubbo/remoting/http12/message/codec/MultipartCodec.java
Outdated
Show resolved
Hide resolved
… 3.3-triple-multipart-codec
dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/utils/UrlUtils.java
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.3 #13387 +/- ##
==========================================
- Coverage 40.40% 40.18% -0.23%
==========================================
Files 1807 1815 +8
Lines 75867 76040 +173
Branches 10642 10662 +20
==========================================
- Hits 30657 30559 -98
- Misses 40911 41180 +269
- Partials 4299 4301 +2 ☔ View full report in Codecov by Sentry. |
… 3.3-triple-multipart-codec
...12/src/main/java/org/apache/dubbo/remoting/http12/netty4/h1/NettyHttp1ConnectionHandler.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/DefaultHttp11ServerTransportListener.java
Outdated
Show resolved
Hide resolved
...n/java/org/apache/dubbo/rpc/protocol/tri/h12/http1/DefaultHttp11ServerTransportListener.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why add this class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's currently used for determine if a HttpCodecFactory
supports certain media type when encoding/decoding (because some codec does not support encoding, or need some special operations to judge).
I will remove this class later, use two interface HttpMessageEncoder
and HttpMessageDecoder
to determine a factory supports encode or decode.
… 3.3-triple-multipart-codec
… 3.3-triple-multipart-codec
|
What version? you can create a separate bug ticket. |
dubbo version: 3.3.0-beta.2 |
What is the purpose of the change
This PR can provide the capacity to decode more HTTP Content-Types for providers.
Brief changelog
Add more HttpMessageCodec to support followding content type:
#13386
The HTTP response is now encoded based on the HTTP headers (accept & grpc-accept-encoding), rather than being limited to JSON or PB.