Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove useless code in ReflectUtils.java #13382

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

thisiswanghy
Copy link
Contributor

Remove useless code

What is the purpose of the change

The findMethodByMethodSignature method in ReflectUtils.java,The signature field is not used

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Remove useless code
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8b8382) 69.56% compared to head (46404d6) 69.53%.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13382      +/-   ##
============================================
- Coverage     69.56%   69.53%   -0.04%     
  Complexity        2        2              
============================================
  Files          1653     1653              
  Lines         71623    71620       -3     
  Branches      10269    10267       -2     
============================================
- Hits          49827    49801      -26     
- Misses        17095    17119      +24     
+ Partials       4701     4700       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thisiswanghy
Copy link
Contributor Author

I looked at the commit history for this class and found that the pr #8684 removes all caching inside ReflectUtils.java, leaving behind the processing of the signature field.

But I don't understand why the cache was removed, it seems to me that it should be kept. I would like to understand the thinking behind removing the cache?

@AlbumenJ
Copy link
Member

I looked at the commit history for this class and found that the pr #8684 removes all caching inside ReflectUtils.java, leaving behind the processing of the signature field.

But I don't understand why the cache was removed, it seems to me that it should be kept. I would like to understand the thinking behind removing the cache?

The cache is global. This will result a reference from Dubbo's classes (usually are GC root) to actual classes. And these classes can not be released after classloader is unused.

@AlbumenJ AlbumenJ merged commit a1642ac into apache:3.2 Nov 20, 2023
14 checks passed
win120a pushed a commit to win120a/dubbo that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants