Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc-triple): Fix missing error code #13379

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

oxsean
Copy link
Collaborator

@oxsean oxsean commented Nov 16, 2023

What is the purpose of the change

Fix ci execution failed due to missing error code

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fe4a9f3) 40.67% compared to head (ed9351e) 40.69%.

❗ Current head ed9351e differs from pull request most recent head b152e5b. Consider uploading reports for the commit b152e5b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13379      +/-   ##
==========================================
+ Coverage   40.67%   40.69%   +0.01%     
==========================================
  Files        1806     1806              
  Lines       75807    75807              
  Branches    10637    10637              
==========================================
+ Hits        30838    30847       +9     
+ Misses      40644    40642       -2     
+ Partials     4325     4318       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oxsean oxsean force-pushed the fix-error-code-inspecting branch 2 times, most recently from 43aa0f2 to ed9351e Compare November 17, 2023 12:53
Copy link

sonarcloud bot commented Nov 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit 633bdbd into apache:3.3 Nov 20, 2023
14 checks passed
@oxsean oxsean deleted the fix-error-code-inspecting branch November 23, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants