Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dubbo.enabled=false not work in actuator configurators #13360

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2b273e) 69.56% compared to head (a44d9c5) 69.58%.
Report is 2 commits behind head on 3.2.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.2   #13360      +/-   ##
============================================
+ Coverage     69.56%   69.58%   +0.02%     
  Complexity        2        2              
============================================
  Files          1652     1652              
  Lines         71608    71608              
  Branches      10264    10264              
============================================
+ Hits          49814    49832      +18     
+ Misses        17098    17086      -12     
+ Partials       4696     4690       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 8daa3dc into apache:3.2 Nov 15, 2023
14 checks passed
AlbumenJ added a commit to AlbumenJ/dubbo-samples that referenced this pull request Nov 15, 2023
@AlbumenJ
Copy link
Member Author

Integration test case: apache/dubbo-samples#1018

AlbumenJ added a commit to apache/dubbo-samples that referenced this pull request Nov 16, 2023
* Add test cases to verify apache/dubbo#13360

* fix script

* fix script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants