fix:Dubbo3TripleGenerator use OuterClassName error #13355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
when
option java_outer_classname
is empty and use Dubbo3TripleGenerator generate code , the DubboxxxServiceTriple has error.My proto file :
and protoc-plugin
generated code DubboTestServiceTriple cannot find the TestServiceOuterClass
![WechatIMG24353](https://private-user-images.githubusercontent.com/30964063/282712743-0bd421f7-bac7-4835-85f4-72b483be3fea.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQzMDM0NTgsIm5iZiI6MTcyNDMwMzE1OCwicGF0aCI6Ii8zMDk2NDA2My8yODI3MTI3NDMtMGJkNDIxZjctYmFjNy00ODM1LTg1ZjQtNzJiNDgzYmUzZmVhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDA1MDU1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTU4YmJjNTYxOTJmZWJlZWRjMWU5NTA2NGE2NGZhOWU4ZDhiMmM5MmViZjk3MmI5NWU0MzVjMDAyNDg3ZTc1MzMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.J3KmMO0rYqIuN33oM1BmXOGQvC_Hbv4jiKa1VGh1W9k)
fixed: Dubbo3TripleGenerator use OuterClassName error
Brief changelog
1、change ProtoType util getJavaOuterClassname method from private to public
2、when
option java_outer_classname
is empty,serviceContext.outerClassName use ProtoType.getJavaOuterClassname method generate.Verifying this change
Checklist