Fix 3.3 application name #13347
Merged
Fix 3.3 application name #13347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dubbo-common/src/main/java/org/apache/dubbo/config/ApplicationConfig.java # dubbo-common/src/main/java/org/apache/dubbo/config/Constants.java
AlbumenJ
requested changes
Nov 14, 2023
Comment on lines
785
to
787
| if (DEFAULT_APP_NAME.equals(applicationConfig.getName())) { | ||
| throw new IllegalStateException("Application name must be set when registry is enabled."); | ||
| } |
There was a problem hiding this comment.
I think it would be better to allow register interface mode if users have not specified the application name. It works in interface mode.
|
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.