-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a new completion state to the deployer #13340
Conversation
Adjust dubbo-samples in pr: apache/dubbo-samples#1015 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change the event order might not a good idea in 3.2.x. Some users have depended on this order to export or refer services.
It might be better to add some other events to implement this functionality for the user.For example, ModuleReadyEvent. |
Yes, and we can make it in 3.3.x. |
I think add some newly events would be a better option. |
How about adding a new state, like completion. |
ok |
dubbo-common/src/main/java/org/apache/dubbo/common/deploy/DeployListener.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
Publish started event after all action done.
before:
![image](https://private-user-images.githubusercontent.com/18413695/281662863-f1cb7074-de57-42d6-952d-fcbb7cd35d2e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTc1ODksIm5iZiI6MTcyNDI5NzI4OSwicGF0aCI6Ii8xODQxMzY5NS8yODE2NjI4NjMtZjFjYjcwNzQtZGU1Ny00MmQ2LTk1MmQtZmNiYjdjZDM1ZDJlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDAzMjgwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk3OTU1YWZlYzkyYTI1ODI5YzJjYmEzYTYwOTBiNDAxYjg2NjVjODBjYWE2ZWFhOTExYTY0MmQ4ODNiZTRiODEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.hxVDJhw3fMPJFESpeCpJTCndxCLOxhrxFGf1NfNiv_s)
![image](https://private-user-images.githubusercontent.com/18413695/281663521-51fc8642-4c0a-4450-9d32-15972b4176cc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTc1ODksIm5iZiI6MTcyNDI5NzI4OSwicGF0aCI6Ii8xODQxMzY5NS8yODE2NjM1MjEtNTFmYzg2NDItNGMwYS00NDUwLTlkMzItMTU5NzJiNDE3NmNjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDAzMjgwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTZkMWI3MjE4ZjhlZjhkN2Q0ODk3MDhhNTk1YmVhZjA5ZGUyNDIyYjUwOTk1NDRhYjUwYTdjNjFjMDNiNTFmNDUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.y_7uii5BJa7aZoczoIWYGE6mIEhPhb2Al7wWCrLX_gs)
after:
![image](https://private-user-images.githubusercontent.com/18413695/281662281-73c35f55-995b-4487-a712-b5e74cd2392c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTc1ODksIm5iZiI6MTcyNDI5NzI4OSwicGF0aCI6Ii8xODQxMzY5NS8yODE2NjIyODEtNzNjMzVmNTUtOTk1Yi00NDg3LWE3MTItYjVlNzRjZDIzOTJjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDAzMjgwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTViZGFkZDc2NDFiZDhjYTdiODY0ODZiYTFkZWM0N2JkOWE3ZjI0ZGZmZmE2YzAwZjc0ZTFlNDhjNTM5YTRkZjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.GlN9MmafWaRXP2IxpuI1uyQcGfP1o3O6v4454LrZf9I)
Brief changelog
Verifying this change
Checklist