Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new completion state to the deployer #13340

Merged
merged 15 commits into from
Nov 29, 2023

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

Publish started event after all action done.

before:
image
image

after:
image

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@finefuture
Copy link
Contributor Author

Adjust dubbo-samples in pr: apache/dubbo-samples#1015

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the event order might not a good idea in 3.2.x. Some users have depended on this order to export or refer services.

@finefuture
Copy link
Contributor Author

Change the event order might not a good idea in 3.2.x. Some users have depended on this order to export or refer services.

It might be better to add some other events to implement this functionality for the user.For example, ModuleReadyEvent.

@AlbumenJ
Copy link
Member

Change the event order might not a good idea in 3.2.x. Some users have depended on this order to export or refer services.

It might be better to add some other events to implement this functionality for the user.For example, ModuleReadyEvent.

Yes, and we can make it in 3.3.x.

@finefuture finefuture changed the base branch from 3.2 to 3.3 November 15, 2023 11:10
@AlbumenJ
Copy link
Member

Change the event order might not a good idea in 3.2.x. Some users have depended on this order to export or refer services.

It might be better to add some other events to implement this functionality for the user.For example, ModuleReadyEvent.

I think add some newly events would be a better option.

@finefuture
Copy link
Contributor Author

Change the event order might not a good idea in 3.2.x. Some users have depended on this order to export or refer services.

It might be better to add some other events to implement this functionality for the user.For example, ModuleReadyEvent.

I think add some newly events would be a better option.

How about adding a new state, like completion.

@AlbumenJ
Copy link
Member

Change the event order might not a good idea in 3.2.x. Some users have depended on this order to export or refer services.

It might be better to add some other events to implement this functionality for the user.For example, ModuleReadyEvent.

I think add some newly events would be a better option.

How about adding a new state, like completion.

ok

@finefuture finefuture changed the title Adjust the order of events in Deployer Adds a new completion state to the deployer Nov 21, 2023
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 3f48269 into apache:3.3 Nov 29, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants