-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix async generic method #13336
Fix async generic method #13336
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.2 #13336 +/- ##
============================================
- Coverage 69.57% 69.55% -0.03%
Complexity 2 2
============================================
Files 1652 1652
Lines 71608 71606 -2
Branches 10264 10263 -1
============================================
- Hits 49819 49802 -17
- Misses 17105 17107 +2
- Partials 4684 4697 +13 see 26 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
@finefuture pls add testcase in RpcUtilsTest |
Okay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
Refer: #13321
![image](https://private-user-images.githubusercontent.com/18413695/281299903-11075743-b97f-4e7f-9ae5-2cadde74d390.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTYzNzgsIm5iZiI6MTcyNDI5NjA3OCwicGF0aCI6Ii8xODQxMzY5NS8yODEyOTk5MDMtMTEwNzU3NDMtYjk3Zi00ZTdmLTlhZTUtMmNhZGRlNzRkMzkwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDAzMDc1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTcxOWYzMmQxNWM5NzIxNmJlMmE4YjJiMzQ5YjI1ZjQxMGVlOTU5ZWQxYjUzMGVkM2Q4ZmUyOTJjNjQ5YTA4MjQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.MPOkrbAD6Ikb3TXZONF9gtYiJuXGUz4AILdxQrBroFk)
The invocation method name is generated based on the method called during reflection proxy, so the method name is "$invokeAsync" when called asynchronously.
![image](https://private-user-images.githubusercontent.com/18413695/281300340-49173fa2-a107-4953-b800-5283f832db91.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQyOTYzNzgsIm5iZiI6MTcyNDI5NjA3OCwicGF0aCI6Ii8xODQxMzY5NS8yODEzMDAzNDAtNDkxNzNmYTItYTEwNy00OTUzLWI4MDAtNTI4M2Y4MzJkYjkxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODIyVDAzMDc1OFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkwZTQzYTZlMzIzZjMzMGYyZTIwMWUwMWFkOWU5NDMyYjE4NDhiMDg1YjczNTIyYTQxZjY0ZWM1NWRhNzgyN2QmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.kwBz0hfBj_kYjvaeC5Mz9F0UEJPkvpoE52QeD1RcpCM)
Brief changelog
Verifying this change
Checklist