Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix async generic method #13336

Merged
merged 9 commits into from
Nov 15, 2023
Merged

Conversation

finefuture
Copy link
Contributor

What is the purpose of the change

Refer: #13321
image

The invocation method name is generated based on the method called during reflection proxy, so the method name is "$invokeAsync" when called asynchronously.
image

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

Merging #13336 (15448c6) into 3.2 (bc749fd) will decrease coverage by 0.03%.
Report is 1 commits behind head on 3.2.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #13336      +/-   ##
============================================
- Coverage     69.57%   69.55%   -0.03%     
  Complexity        2        2              
============================================
  Files          1652     1652              
  Lines         71608    71606       -2     
  Branches      10264    10263       -1     
============================================
- Hits          49819    49802      -17     
- Misses        17105    17107       +2     
- Partials       4684     4697      +13     

see 26 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@wxbty
Copy link
Member

wxbty commented Nov 14, 2023

@finefuture pls add testcase in RpcUtilsTest

@finefuture
Copy link
Contributor Author

@finefuture pls add testcase in RpcUtilsTest

Okay.

Copy link
Member

@songxiaosheng songxiaosheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Get the same method name and parameters as the filled one

LGTM

Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

93.8% 93.8% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit b74cf5b into apache:3.2 Nov 15, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants