Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance logs for none serializable #13326

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Enhance logs for none serializable #13326

merged 2 commits into from
Nov 20, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Nov 7, 2023

What is the purpose of the change

Log if class is not implement Serializable interface even if disable checkSerializable option.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

# Conflicts:
#	dubbo-common/src/main/java/org/apache/dubbo/common/utils/DefaultSerializeClassChecker.java
Copy link

sonarcloud bot commented Nov 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8daa3dc) 69.59% compared to head (f05633e) 69.60%.
Report is 4 commits behind head on 3.2.

Additional details and impacted files
@@            Coverage Diff            @@
##                3.2   #13326   +/-   ##
=========================================
  Coverage     69.59%   69.60%           
  Complexity        2        2           
=========================================
  Files          1652     1652           
  Lines         71608    71609    +1     
  Branches      10264    10264           
=========================================
+ Hits          49833    49840    +7     
+ Misses        17077    17075    -2     
+ Partials       4698     4694    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 43e78d1 into apache:3.2 Nov 20, 2023
14 checks passed
win120a pushed a commit to win120a/dubbo that referenced this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants