Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[System properties] Add the system properties tool, unified system configuration items #13307

Merged
merged 38 commits into from
Nov 20, 2023
Merged

Conversation

Skylark-hjyp
Copy link

What is the purpose of the change

Add the system properties tool, unified system configuration items.

Brief changelog

Add class of SystemPropertyConfigUtils and SystemPropertyConfigUtilsTest.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@CrazyHZM
Copy link
Member

CrazyHZM commented Nov 6, 2023

All configuration items that use System.getProperty can be divided into three categories

  1. Configuration items defined by dubbo itself
  2. Configuration items defined by the three-party component
  3. System configuration item
    Each of these three categories should use Constants to distinguish between keys that manage their configuration items.
    @Tomoko-hjf

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (633bdbd) 40.68% compared to head (0247ba3) 40.71%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.3   #13307      +/-   ##
==========================================
+ Coverage   40.68%   40.71%   +0.03%     
==========================================
  Files        1806     1807       +1     
  Lines       75805    75834      +29     
  Branches    10636    10641       +5     
==========================================
+ Hits        30841    30878      +37     
+ Misses      40639    40637       -2     
+ Partials     4325     4319       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ changed the title 【System properties 】Add the system properties tool, unified system configuration items [System properties] Add the system properties tool, unified system configuration items Nov 14, 2023
@Skylark-hjyp
Copy link
Author

@CrazyHZM The native image CI pass, another CI does not pass, and it does not pass in any other PR. Please review again~

1700200037968

Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Skylark-hjyp
Copy link
Author

@CrazyHZM All CI have passed. Please review again~

@CrazyHZM CrazyHZM merged commit f441e79 into apache:3.3 Nov 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants