-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added scheduler closure check during RegistryNotifier notify. #13273
Conversation
Hello, I'm seeing a CI error that says: "TEST FAILURE: case config not found: /home/runner/work/dubbo/dubbo/1-basic/dubbo-samples-spring-xml/case-configuration.yml," but I haven't made any changes to the relevant logic. Why did this CI error occur? |
if (delay) { | ||
// when the scheduler is shutdown, no notification is sent | ||
if (scheduler.isShutdown()) { | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we shoud log something here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get
Codecov Report
@@ Coverage Diff @@
## 3.2 #13273 +/- ##
============================================
- Coverage 69.49% 69.43% -0.06%
Complexity 2 2
============================================
Files 1653 1652 -1
Lines 68942 68961 +19
Branches 10048 10058 +10
============================================
- Hits 47911 47885 -26
- Misses 16392 16420 +28
- Partials 4639 4656 +17 see 63 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
// when the scheduler is shutdown, no notification is sent | ||
if (scheduler.isShutdown()) { | ||
if (logger.isWarnEnabled()) { | ||
logger.warn(COMMON_FAILED_NOTIFY_EVENT, "", "", "Notification scheduler is off, no notifications are sent."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also log the registry url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
get.
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
alibaba/nacos#11294
Brief changelog
Verifying this change
Checklist