Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move dubbo-compiler into dubbo-plugin #13266

Merged
merged 2 commits into from
Oct 26, 2023

Conversation

CrazyHZM
Copy link
Member

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #13266 (eaa2f8b) into 3.3 (c98c487) will decrease coverage by 0.42%.
Report is 1 commits behind head on 3.3.
The diff coverage is n/a.

❗ Current head eaa2f8b differs from pull request most recent head cd03e22. Consider uploading reports for the commit cd03e22 to get more accurate results

@@             Coverage Diff              @@
##                3.3   #13266      +/-   ##
============================================
- Coverage     68.41%   67.99%   -0.42%     
  Complexity        8        8              
============================================
  Files          1718     1726       +8     
  Lines         70833    71239     +406     
  Branches      10238    10287      +49     
============================================
- Hits          48460    48442      -18     
- Misses        17683    18104     +421     
- Partials       4690     4693       +3     

see 34 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit ba94cf0 into apache:3.3 Oct 26, 2023
14 checks passed
@oxsean
Copy link
Collaborator

oxsean commented Oct 30, 2023

Led to compilation failure in the dubbo-rpc-triple module

@CrazyHZM CrazyHZM deleted the feat/move_dubbo_compiler branch October 30, 2023 07:09
@CrazyHZM CrazyHZM mentioned this pull request Oct 30, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants