Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Optimize code in MethodConfigTest, and add a new test.
Brief changelog
convertMethodConfig2AsyncInfo
test in theMethodConfigTest
class indubbo-config-api
module, which was added indubbo-compatible
module.MethodConfigTest
class in thedubbo-compatible
module should testMethodConfig
class incom.alibaba.dubbo.config
package instead of the class with the same name inorg.apache.dubbo.config
package, which is tested in another test class.assertEquals
andassertThat
, the type erasure mechanism will do it (the matcher will eventually be treated asMatcher<Map>
instead ofMatcher<Map<Object, Object>>
).Verifying this change
run both MethodConfigTest.
Checklist