Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize MethodConfigTest #13234

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

Linchen-Xu
Copy link
Contributor

@Linchen-Xu Linchen-Xu commented Oct 19, 2023

What is the purpose of the change

Optimize code in MethodConfigTest, and add a new test.

Brief changelog

  • Remove unnecessary exception throw code
  • Add the convertMethodConfig2AsyncInfo test in the MethodConfigTest class in dubbo-config-api module, which was added in dubbo-compatible module.
  • The MethodConfigTest class in the dubbo-compatible module should test MethodConfig class in com.alibaba.dubbo.config package instead of the class with the same name in org.apache.dubbo.config package, which is tested in another test class.
  • Remove the unnecessary manual cast from String type to Object type when calling assertEquals and assertThat, the type erasure mechanism will do it (the matcher will eventually be treated as Matcher<Map> instead of Matcher<Map<Object, Object>>).

Verifying this change

run both MethodConfigTest.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Linchen-Xu Linchen-Xu changed the title Optimize MethodConfigTest feat: optimize MethodConfigTest Oct 19, 2023
@AlbumenJ AlbumenJ merged commit b41fe3c into apache:3.2 Oct 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants