Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix triple method override #13224

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Fix triple method override #13224

merged 3 commits into from
Oct 18, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Fix #13222

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #13224 (5922499) into 3.2 (a4a3fd7) will increase coverage by 0.06%.
Report is 10 commits behind head on 3.2.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #13224      +/-   ##
============================================
+ Coverage     69.44%   69.51%   +0.06%     
  Complexity        2        2              
============================================
  Files          1649     1649              
  Lines         68725    68725              
  Branches      10014    10013       -1     
============================================
+ Hits          47728    47771      +43     
+ Misses        16405    16366      -39     
+ Partials       4592     4588       -4     

see 35 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

88.9% 88.9% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@guohao guohao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EarthChen EarthChen merged commit f995ef5 into apache:3.2 Oct 18, 2023
14 checks passed
AlbumenJ added a commit to AlbumenJ/dubbo-samples that referenced this pull request Oct 18, 2023
AlbumenJ added a commit to apache/dubbo-samples that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PackableMethod share while services cause serialization error
4 participants