Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct dependency of alibaba dubbo #13218

Merged
merged 6 commits into from
Oct 19, 2023
Merged

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Oct 17, 2023

What is the purpose of the change

Newly added options

  • dubbo.compact.enable to indicate that whether load Alibaba Dubbo related classes or not

Brief changes

  • Add org.apache.dubbo.common.compact.Dubbo2CompactUtils to support disable load alibaba dubbo dependencies
  • Move all direct dependencies into dubbo-compactable module
  • Check if load com.alibaba extensions in ExtensionLoader

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 66 Code Smells

15.9% 15.9% Coverage
2.3% 2.3% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #13218 (a6ec6ca) into 3.2 (a4a3fd7) will decrease coverage by 0.04%.
Report is 12 commits behind head on 3.2.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #13218      +/-   ##
============================================
- Coverage     69.44%   69.41%   -0.04%     
  Complexity        2        2              
============================================
  Files          1649     1651       +2     
  Lines         68725    68913     +188     
  Branches      10014    10043      +29     
============================================
+ Hits          47728    47834     +106     
- Misses        16405    16458      +53     
- Partials       4592     4621      +29     

see 47 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
But one question is, if there are no users who dependence on dubbo-compatible, will there be some related classes that can't be found? Such as com.alibaba.dubbo.config.annotation.Reference. @AlbumenJ

@AlbumenJ
Copy link
Member Author

LGTM. But one question is, if there are no users who dependence on dubbo-compatible, will there be some related classes that can't be found? Such as com.alibaba.dubbo.config.annotation.Reference. @AlbumenJ

Currently, dubbo-all depends on dubbo-compatible. In the future, maybe 3.3 or 3.4, we can remove it and provide a pure jar.

@CrazyHZM CrazyHZM merged commit 0d91d41 into apache:3.2 Oct 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants