Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Similarly, to #13153, I noticed that in both
testNonEcho
andtestEcho
test cases, there's repetitive creation of mock forinvocation
andinvoker
. To make the test code cleaner, more readable, and easier to maintain, I've taken this refactoring.Brief changelog
I introduced two methods:
createMockRpcInvocation
andcreateMockInvoker
. In the two tests, I removed the redundant mock creation sections and instead call these methods to create the mocks.Verifying this change
Checklist