Fix wrong return types for StubMethodDescriptor #13200

namelessssssssssss · 2023-10-14T06:31:41Z

The StubMethodDescriptor seems to have wrong returnTypes when initialized.

   public StubMethodDescriptor(String methodName,
        Class<?> requestClass,
        Class<?> responseClass,
        StubServiceDescriptor serviceDescriptor,
        RpcType rpcType,
        Pack requestPack,
        Pack responsePack,
        UnPack requestUnpack,
        UnPack responseUnpack) {
        this.methodName = methodName;
        this.serviceDescriptor = serviceDescriptor;
        this.rpcType = rpcType;
        this.requestPack = requestPack;
        this.responsePack = responsePack;
        this.responseUnpack = responseUnpack;
        this.requestUnpack = requestUnpack;
        this.parameterClasses = new Class<?>[]{requestClass};
        this.returnClass = responseClass;
        this.paramDesc = ReflectUtils.getDesc(parameterClasses);
        this.compatibleParamSignatures = Stream.of(parameterClasses).map(Class::getName).toArray(String[]::new);
       //It this correct?
        this.returnTypes = new Type[]{requestClass, requestClass};
        serviceDescriptor.addMethod(this);
    }

This problem has no effect if we only use triple protocol, because TripleInvoker only use param returnClass to get method return type.
But it may cause a serialization problem when other protocols use protobuf serialization with triple stub.

codecov-commenter · 2023-10-14T07:40:56Z

Codecov Report

❗ No coverage uploaded for pull request base (3.3@3e50bdd). Click here to learn what that means.
The diff coverage is n/a.

@@          Coverage Diff           @@
##             3.3   #13200   +/-   ##
======================================
  Coverage       ?   68.41%           
  Complexity     ?        8           
======================================
  Files          ?     1717           
  Lines          ?    70801           
  Branches       ?    10236           
======================================
  Hits           ?    48437           
  Misses         ?    17681           
  Partials       ?     4683

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more