-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong return types for StubMethodDescriptor #13200
Fix wrong return types for StubMethodDescriptor #13200
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.3 #13200 +/- ##
======================================
Coverage ? 68.41%
Complexity ? 8
======================================
Files ? 1717
Lines ? 70801
Branches ? 10236
======================================
Hits ? 48437
Misses ? 17681
Partials ? 4683 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EarthChen @icodening PTAL
issue #13158 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please also fix on 3.2 |
The
StubMethodDescriptor
seems to have wrongreturnTypes
when initialized.This problem has no effect if we only use triple protocol, because
TripleInvoker
only use paramreturnClass
to get method return type.But it may cause a serialization problem when other protocols use protobuf serialization with triple stub.