Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VirtualThreadPool apache license #13157

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

CrazyHZM
Copy link
Member

@CrazyHZM CrazyHZM commented Oct 8, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Signed-off-by: crazyhzm <crazyhzm@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #13157 (4bac2a3) into 3.3 (c96a8f3) will increase coverage by 0.00%.
Report is 28 commits behind head on 3.3.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                3.3   #13157   +/-   ##
=========================================
  Coverage     68.40%   68.41%           
- Complexity        6        8    +2     
=========================================
  Files          1717     1718    +1     
  Lines         70668    70687   +19     
  Branches      10224    10222    -2     
=========================================
+ Hits          48340    48360   +20     
- Misses        17632    17647   +15     
+ Partials       4696     4680   -16     

see 66 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CrazyHZM CrazyHZM merged commit 0dab17f into apache:3.3 Oct 8, 2023
14 checks passed
@CrazyHZM CrazyHZM deleted the fix/virtual_license branch October 8, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants