-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protobuf method not allow override #13155
Conversation
...bbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/ReflectionPackableMethod.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ReflectionServiceDescriptor.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 3.2 #13155 +/- ##
======================================
Coverage ? 69.49%
Complexity ? 2
======================================
Files ? 1650
Lines ? 68729
Branches ? 10012
======================================
Hits ? 47760
Misses ? 16374
Partials ? 4595 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
pls add some ut & it. |
i added some in dubbo-rpc-triple/test/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocolTest.java |
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ReflectionServiceDescriptor.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ReflectionServiceDescriptor.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/main/java/org/apache/dubbo/rpc/model/ReflectionServiceDescriptor.java
Outdated
Show resolved
Hide resolved
...rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocolTest.java
Outdated
Show resolved
Hide resolved
pls format your code by dubbo checkstyle |
ok,my pleasure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
`public class ProtobufUtils {
} |
dubbo-common/src/main/java/org/apache/dubbo/common/utils/ProtobufUtils.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/main/java/org/apache/dubbo/common/utils/ProtobufUtils.java
Outdated
Show resolved
Hide resolved
pls fix conflicts |
resolved |
Kudos, SonarCloud Quality Gate passed! |
i found tri protocol,if the provider create two stream method like below,invoke streamserver method will invoke the wrong method,is this a right behavior
}` |
What is the purpose of the change
Fix protobuf method overrided cause provider NPE.See #13142
Brief changelog
Verifying this change
Checklist