-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix https://github.com/apache/dubbo/issues/13135 #13139
Conversation
dubbo-cluster/pom.xml
Outdated
<dependency> | ||
<groupId>org.openjdk.nashorn</groupId> | ||
<artifactId>nashorn-core</artifactId> | ||
<version>${nashorn-core.version}</version> | ||
</dependency> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test scope would be better. We should not import such engine by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll change it to "testing".
@AlbumenJ process successful. |
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## 3.2 #13139 +/- ##
============================================
+ Coverage 69.38% 69.40% +0.02%
Complexity 2 2
============================================
Files 1649 1649
Lines 68722 68724 +2
Branches 10012 10013 +1
============================================
+ Hits 47680 47699 +19
+ Misses 16462 16429 -33
- Partials 4580 4596 +16 see 28 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
What is the purpose of the change
add openjdk support javascript unit test jar pom
Brief changelog
Fix the problem of maven build interruption due to lack of js script parsing jar package
Verifying this change
build successful!
Checklist