Fix RejectException #12950

finefuture · 2023-08-23T03:39:04Z

What is the purpose of the change

If executor was shutdown, shouldn't submit task.

Brief changelog

Verifying this change

Checklist

Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
Add some description to dubbo-website project if you are requesting to add a feature.
GitHub Actions works fine on your own branch.
If this contribution is large, please follow the Software Donation Guide.

AlbumenJ

@guohao @EarthChen @icodening PTAL

dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java

codecov-commenter · 2023-08-28T09:19:12Z

Codecov Report

Merging #12950 (e93c690) into 3.2 (8068c99) will decrease coverage by 0.37%.
Report is 10 commits behind head on 3.2.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12950      +/-   ##
============================================
- Coverage     69.87%   69.51%   -0.37%     
+ Complexity      113        2     -111     
============================================
  Files          1875     1649     -226     
  Lines         99205    68489   -30716     
  Branches      17827     9995    -7832     
============================================
- Hits          69320    47608   -21712     
+ Misses        24326    16285    -8041     
+ Partials       5559     4596     -963

see 3524 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sonarcloud · 2023-08-28T12:03:39Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

65.4% Coverage
0.0% Duplication

EarthChen

LGTM

bert82503 · 2023-09-08T02:14:51Z

we use dubbo-3.2.5, encounter the same issue.

message:[DUBBO] Meet Exception on ClientResponseHandler, status code is: INTERNAL, dubbo version: 3.2.5, current host: *, error code: 4-10. This may be caused by , go to https://dubbo.apache.org/faq/4/10 to find instructions.
logger:org.apache.dubbo.rpc.protocol.tri.transport.TripleHttp2ClientResponseHandler
level:WARN
trace_id:N/A
exception:java.util.concurrent.RejectedExecutionException: null 
  at org.apache.dubbo.common.threadpool.ThreadlessExecutor.execute(ThreadlessExecutor.java:101) 
  at org.apache.dubbo.common.threadpool.serial.SerializingExecutor.schedule(SerializingExecutor.java:71) 
  at org.apache.dubbo.common.threadpool.serial.SerializingExecutor.execute(SerializingExecutor.java:64) at org.apache.dubbo.rpc.protocol.tri.stream.TripleClientStream$ClientTransportListener.onHeader(TripleClientStream.java:433) 
  at org.apache.dubbo.rpc.protocol.tri.transport.TripleHttp2ClientResponseHandler.channelRead0(TripleHttp2ClientResponseHandler.java:65) 
  at org.apache.dubbo.rpc.protocol.tri.transport.TripleHttp2ClientResponseHandler.channelRead0(TripleHttp2ClientResponseHandler.java:35) 
  at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:99) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) 
  at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) 
  at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) 
  at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) 
  at io.netty.handler.codec.http2.AbstractHttp2StreamChannel$Http2ChannelUnsafe.doRead0(AbstractHttp2StreamChannel.java:939) 
  at io.netty.handler.codec.http2.AbstractHttp2StreamChannel.fireChildRead(AbstractHttp2StreamChannel.java:584) 
  at io.netty.handler.codec.http2.Http2MultiplexHandler.channelRead(Http2MultiplexHandler.java:186) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:442) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) 
  at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) 
  at io.netty.handler.codec.http2.Http2FrameCodec.onHttp2Frame(Http2FrameCodec.java:712) 
  at io.netty.handler.codec.http2.Http2FrameCodec$FrameListener.onHeadersRead(Http2FrameCodec.java:644) 
  at io.netty.handler.codec.http2.Http2FrameCodec$FrameListener.onHeadersRead(Http2FrameCodec.java:638) 
  at io.netty.handler.codec.http2.Http2FrameListenerDecorator.onHeadersRead(Http2FrameListenerDecorator.java:48) 
  at io.netty.handler.codec.http2.Http2EmptyDataFrameListener.onHeadersRead(Http2EmptyDataFrameListener.java:63) 
  at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener.onHeadersRead(DefaultHttp2ConnectionDecoder.java:409) 
  at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder$FrameReadListener.onHeadersRead(DefaultHttp2ConnectionDecoder.java:337) 
  at io.netty.handler.codec.http2.Http2InboundFrameLogger$1.onHeadersRead(Http2InboundFrameLogger.java:56) 
  at io.netty.handler.codec.http2.DefaultHttp2FrameReader$2.processFragment(DefaultHttp2FrameReader.java:476) 
  at io.netty.handler.codec.http2.DefaultHttp2FrameReader.readHeadersFrame(DefaultHttp2FrameReader.java:484) 
  at io.netty.handler.codec.http2.DefaultHttp2FrameReader.processPayloadState(DefaultHttp2FrameReader.java:253) 
  at io.netty.handler.codec.http2.DefaultHttp2FrameReader.readFrame(DefaultHttp2FrameReader.java:159) 
  at io.netty.handler.codec.http2.Http2InboundFrameLogger.readFrame(Http2InboundFrameLogger.java:41) 
  at io.netty.handler.codec.http2.DefaultHttp2ConnectionDecoder.decodeFrame(DefaultHttp2ConnectionDecoder.java:173) 
  at io.netty.handler.codec.http2.DecoratingHttp2ConnectionDecoder.decodeFrame(DecoratingHttp2ConnectionDecoder.java:63) 
  at io.netty.handler.codec.http2.Http2ConnectionHandler$FrameDecoder.decode(Http2ConnectionHandler.java:393) 
  at io.netty.handler.codec.http2.Http2ConnectionHandler.decode(Http2ConnectionHandler.java:453) 
  at io.netty.handler.codec.ByteToMessageDecoder.decodeRemovalReentryProtection(ByteToMessageDecoder.java:529) 
  at io.netty.handler.codec.ByteToMessageDecoder.callDecode(ByteToMessageDecoder.java:468) 
  at io.netty.handler.codec.ByteToMessageDecoder.channelRead(ByteToMessageDecoder.java:290) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:444) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) 
  at io.netty.channel.AbstractChannelHandlerContext.fireChannelRead(AbstractChannelHandlerContext.java:412) 
  at io.netty.channel.DefaultChannelPipeline$HeadContext.channelRead(DefaultChannelPipeline.java:1410) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:440) 
  at io.netty.channel.AbstractChannelHandlerContext.invokeChannelRead(AbstractChannelHandlerContext.java:420) 
  at io.netty.channel.DefaultChannelPipeline.fireChannelRead(DefaultChannelPipeline.java:919) 
  at io.netty.channel.nio.AbstractNioByteChannel$NioByteUnsafe.read(AbstractNioByteChannel.java:166) 
  at io.netty.channel.nio.NioEventLoop.processSelectedKey(NioEventLoop.java:788) 
  at io.netty.channel.nio.NioEventLoop.processSelectedKeysOptimized(NioEventLoop.java:724) 
  at io.netty.channel.nio.NioEventLoop.processSelectedKeys(NioEventLoop.java:650) 
  at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:562) 
  at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:997) 
  at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) 
  at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) 
  at java.lang.Thread.run(Thread.java:750)

dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java

sonarcloud · 2023-10-11T04:29:18Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

65.4% Coverage
0.0% Duplication

icodening

LGTM

finefuture added 2 commits August 23, 2023 11:01

fix RejectException null

e6331df

fix reference

d20ec17

AlbumenJ reviewed Aug 24, 2023

View reviewed changes

AlbumenJ requested a review from icodening August 24, 2023 03:52

AlbumenJ assigned guohao and EarthChen and unassigned guohao and EarthChen Aug 24, 2023

AlbumenJ requested review from guohao and EarthChen August 24, 2023 03:52

icodening requested changes Aug 27, 2023

View reviewed changes

dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java Outdated Show resolved Hide resolved

finefuture added 2 commits August 28, 2023 16:03

use isTerminated judge Executor

abebab8

use isShutdown judge Executor

e93c690

EarthChen approved these changes Sep 1, 2023

View reviewed changes

finefuture requested a review from icodening September 1, 2023 09:59

AlbumenJ approved these changes Sep 5, 2023

View reviewed changes

bert82503 reviewed Sep 8, 2023

View reviewed changes

dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java Outdated Show resolved Hide resolved

bert82503 reviewed Sep 8, 2023

View reviewed changes

dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java Outdated Show resolved Hide resolved

Merge branch '3.2' into 3.2-executor-refactor

9f9bb37

icodening approved these changes Oct 11, 2023

View reviewed changes

icodening merged commit c10d95b into apache:3.2 Oct 11, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix RejectException #12950

Fix RejectException #12950

finefuture commented Aug 23, 2023

AlbumenJ left a comment

codecov-commenter commented Aug 28, 2023

sonarcloud bot commented Aug 28, 2023

EarthChen left a comment

bert82503 commented Sep 8, 2023 •

edited

Loading

sonarcloud bot commented Oct 11, 2023

icodening left a comment

Fix RejectException #12950

Fix RejectException #12950

Conversation

finefuture commented Aug 23, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

AlbumenJ left a comment

Choose a reason for hiding this comment

codecov-commenter commented Aug 28, 2023

Codecov Report

sonarcloud bot commented Aug 28, 2023

EarthChen left a comment

Choose a reason for hiding this comment

bert82503 commented Sep 8, 2023 • edited Loading

sonarcloud bot commented Oct 11, 2023

icodening left a comment

Choose a reason for hiding this comment

bert82503 commented Sep 8, 2023 •

edited

Loading