-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RejectException #12950
Fix RejectException #12950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guohao @EarthChen @icodening PTAL
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## 3.2 #12950 +/- ##
============================================
- Coverage 69.87% 69.51% -0.37%
+ Complexity 113 2 -111
============================================
Files 1875 1649 -226
Lines 99205 68489 -30716
Branches 17827 9995 -7832
============================================
- Hits 69320 47608 -21712
+ Misses 24326 16285 -8041
+ Partials 5559 4596 -963 see 3524 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
we use
|
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java
Outdated
Show resolved
Hide resolved
dubbo-common/src/main/java/org/apache/dubbo/common/threadpool/serial/SerializingExecutor.java
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What is the purpose of the change
If executor was shutdown, shouldn't submit task.
Brief changelog
Verifying this change
Checklist