Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dubbo provider lose when zookeeper restored to normal after network fluctuations.(#12646) #12740

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

qijun4tian
Copy link
Contributor

What is the purpose of the change

fix(#12646 ) 在zookeeper 恢复后,由于之前的session创建的Ephermal节点未及时删除导致provider 不能再次注册上的问题

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #12740 (eca7f30) into 3.2 (bd76d04) will decrease coverage by 0.36%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12740      +/-   ##
============================================
- Coverage     69.70%   69.34%   -0.36%     
+ Complexity      318        2     -316     
============================================
  Files          3517     1647    -1870     
  Lines        166885    68208   -98677     
  Branches      27942     9969   -17973     
============================================
- Hits         116322    47300   -69022     
+ Misses        40483    16351   -24132     
+ Partials      10080     4557    -5523     

see 1898 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@qijun4tian qijun4tian changed the title fix dubbo provider lose when zk restart (#12646) fix dubbo provider lose when zookeeper restored to normal after network fluctuations.(#12646) Jul 18, 2023
@AlbumenJ AlbumenJ merged commit c54e1b6 into apache:3.2 Jul 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants