-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add netty4 metrics. #12695
add netty4 metrics. #12695
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is best to add a switch to control whether this ability is enabled
Codecov Report
@@ Coverage Diff @@
## 3.3 #12695 +/- ##
============================================
+ Coverage 65.81% 68.13% +2.32%
Complexity 6 6
============================================
Files 1834 1704 -130
Lines 73496 70203 -3293
Branches 10437 10184 -253
============================================
- Hits 48369 47836 -533
+ Misses 20431 17721 -2710
+ Partials 4696 4646 -50 see 187 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on 3.3 branch, this is a new feature
…o feature_netty_metrics
* RequestEvent optimization * RequestEvent optimization * RequestEvent optimization(apache#12655) * RequestEvent optimization(apache#12655) * fix conflict * code optimize * code optimize * optimize --------- Co-authored-by: songxiaosheng <songxiaosheng@elastic.link>
eartbeat=60000&interface=org.apache.dubbo.spring.boot.api.HelloService&methods=sayHello&pid=9&prefer.serialization=fastjson2,hessian2&qos.enable=false&release=3.2.5-SNAPSHOT&revision=1.0.0&service-name-mapping=true&side=provider×tamp=1689776520246&token=d21bf92b-dc41-4ff6-a261-d8e8f10b5087&version=1.0.0) Failed to bind NettyServer on /0.0.0.0:20880, cause: io.netty.buffer.PooledByteBufAllocator.metric()Lio/netty/buffer/PooledByteBufAllocatorMetric; |
please fix conflits |
# Conflicts: # dubbo-distribution/dubbo-bom/pom.xml # dubbo-metrics/pom.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
private boolean isSupportMetrics() { | ||
return ClassUtils.isPresent("io.netty.buffer.PooledByteBufAllocatorMetric", NettyServer.class.getClassLoader()) && | ||
ClassUtils.isPresent("io.netty.handler.codec.compression.EncoderUtil", NettyServer.class.getClassLoader()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里为何要判断EncoderUtil这个类型,没看到后面指标使用了这个类型,
@AlbumenJ PTAL |
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
增加netty相关指标,详情:##12271
Brief changelog
监控指标类型
指标详情
Tags: "id" (unique id for the allocator), "allocator.type" (pooled, unpooled), "memory.type" (heap, direct)
Tags: "id" (unique id for the allocator), "allocator.type" (pooled, unpooled), "memory.type" (heap, direct)
Tags: "id" (unique id for the allocator), "allocator.type" (pooled, unpooled), "memory.type" (heap, direct)
Tags: "id" (unique id for the allocator), "allocator.type" (pooled, unpooled), "cache.type" (normal, small)
Tags: "id" (unique id for the allocator), "allocator.type" (pooled, unpooled)
Tags: "id" (unique id for the allocator), "allocator.type" (pooled, unpooled)
Tags: "name" (unique name for the event executor)
Verifying this change
Checklist