Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename getModelEnvironment to modelEnvironment #12551

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

Fix #12542
Fix #12121
Fix #11785

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarcloud
Copy link

sonarcloud bot commented Jun 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

25.8% 25.8% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2023

Codecov Report

Merging #12551 (4276aa4) into 3.2 (467622a) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #12551      +/-   ##
============================================
- Coverage     69.44%   69.22%   -0.22%     
+ Complexity      338        2     -336     
============================================
  Files          3496     1637    -1859     
  Lines        165133    67525   -97608     
  Branches      27752     9907   -17845     
============================================
- Hits         114674    46745   -67929     
+ Misses        40423    16257   -24166     
+ Partials      10036     4523    -5513     

see 1880 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit 3160602 into apache:3.2 Jun 19, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment