fix: Adjusting cluster invoker checks #12139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLFutureX
changed the title
Codecov Report
@@ Coverage Diff @@
## 3.2 #12139 +/- ##
============================================
- Coverage 69.94% 69.58% -0.37%
+ Complexity 341 2 -339
============================================
Files 3403 1593 -1810
Lines 159313 65397 -93916
Branches 26427 9522 -16905
============================================
- Hits 111430 45504 -65926
+ Misses 38216 15511 -22705
+ Partials 9667 4382 -5285 see 1852 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlbumenJ
requested changes
Apr 20, 2023
| import org.apache.dubbo.rpc.Result; | ||
| import org.apache.dubbo.rpc.RpcContext; | ||
| import org.apache.dubbo.rpc.RpcInvocation; | ||
| import org.apache.dubbo.rpc.*; |
AlbumenJ
requested changes
Apr 20, 2023
| @@ -331,6 +331,8 @@ public Result invoke(final Invocation invocation) throws RpcException { | |||
|
|
|||
| InvocationProfilerUtils.enterDetailProfiler(invocation, () -> "Router route."); | |||
| List<Invoker<T>> invokers = list(invocation); | |||
|
|
|||
| checkInvokers(invokers, invocation); | |||
There was a problem hiding this comment.
Exception may throws here and will case memory leak of DetailProfiler
|
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue