-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adjusting cluster invoker checks #12139
fix: Adjusting cluster invoker checks #12139
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.2 #12139 +/- ##
============================================
- Coverage 69.94% 69.58% -0.37%
+ Complexity 341 2 -339
============================================
Files 3403 1593 -1810
Lines 159313 65397 -93916
Branches 26427 9522 -16905
============================================
- Hits 111430 45504 -65926
+ Misses 38216 15511 -22705
+ Partials 9667 4382 -5285 see 1852 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
import org.apache.dubbo.rpc.Result; | ||
import org.apache.dubbo.rpc.RpcContext; | ||
import org.apache.dubbo.rpc.RpcInvocation; | ||
import org.apache.dubbo.rpc.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert comma import
@@ -331,6 +331,8 @@ public Result invoke(final Invocation invocation) throws RpcException { | |||
|
|||
InvocationProfilerUtils.enterDetailProfiler(invocation, () -> "Router route."); | |||
List<Invoker<T>> invokers = list(invocation); | |||
|
|||
checkInvokers(invokers, invocation); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exception may throws here and will case memory leak of DetailProfiler
Kudos, SonarCloud Quality Gate passed! |
issue