Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Invocation#getInvokedInvokers to get invokers for ClusterFilter #11359

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

    /**
     * To add invoked invokers into invocation. Can be used in ClusterFilter or Filter for tracing or debugging purpose.
     * Currently, only support in consumer side.
     *
     * @param invoker invoked invokers
     */
    void addInvokedInvoker(Invoker<?> invoker);

    /**
     * Get all invoked invokers in current invocation.
     * NOTICE: A curtain invoker could be invoked for twice or more if retries.
     *
     * @return invokers
     */
    List<Invoker<?>> getInvokedInvokers();

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11359 (32ff8f2) into 3.2 (f0764b3) will decrease coverage by 4.56%.
The diff coverage is 50.00%.

@@             Coverage Diff              @@
##                3.2   #11359      +/-   ##
============================================
- Coverage     69.39%   64.83%   -4.56%     
+ Complexity      132       14     -118     
============================================
  Files          1514     1487      -27     
  Lines         81223    62370   -18853     
  Branches      14407     9133    -5274     
============================================
- Hits          56366    40439   -15927     
+ Misses        20043    17711    -2332     
+ Partials       4814     4220     -594     
Impacted Files Coverage Δ
...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java 8.33% <0.00%> (-0.56%) ⬇️
...main/java/com/alibaba/dubbo/rpc/RpcInvocation.java 0.00% <0.00%> (ø)
...src/main/java/org/apache/dubbo/rpc/Invocation.java 20.00% <ø> (ø)
...bo/rpc/cluster/support/AbstractClusterInvoker.java 79.60% <100.00%> (-4.66%) ⬇️
.../main/java/org/apache/dubbo/rpc/RpcInvocation.java 70.00% <100.00%> (-2.12%) ⬇️
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
... and 483 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlbumenJ AlbumenJ merged commit cbcbac9 into apache:3.2 Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants