Bump Maven Wrapper to 3.8.7 #11260

sconvent · 2023-01-09T20:56:29Z

What is the purpose of the change

The used Maven version and Maven Wrapper version are out of date.

Brief changelog

Bumping Maven version to 3.8.7
Using the latest distribution of the Maven Wrapper

All of these changes were made using the recommended way with the following command:
mvn wrapper:wrapper -Dmaven=3.8.7

Verifying this change

Just via CI

Checklist

Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
Each commit in the pull request should have a meaningful subject line and body.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
Add some description to dubbo-website project if you are requesting to add a feature.
GitHub Actions works fine on your own branch.
If this contribution is large, please follow the Software Donation Guide.

AlbumenJ

Should we download .mvn/wrapper/maven-wrapper.jar in runtime instead of source provided?

codecov-commenter · 2023-01-10T02:52:27Z

Codecov Report

Merging #11260 (adeb1ab) into 3.2 (d8e6dfa) will decrease coverage by 4.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11260      +/-   ##
============================================
- Coverage     69.54%   65.04%   -4.51%     
+ Complexity      132       14     -118     
============================================
  Files          1503     1479      -24     
  Lines         80071    61746   -18325     
  Branches      14133     9045    -5088     
============================================
- Hits          55688    40161   -15527     
+ Misses        19591    17384    -2207     
+ Partials       4792     4201     -591

Impacted Files	Coverage Δ
...luster/router/script/ScriptStateRouterFactory.java	`0.00% <0.00%> (-100.00%)`	⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java	`0.00% <0.00%> (-100.00%)`	⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java	`0.00% <0.00%> (-100.00%)`	⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java	`0.00% <0.00%> (-100.00%)`	⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java	`0.00% <0.00%> (-100.00%)`	⬇️
...sian2/dubbo/DefaultHessian2FactoryInitializer.java	`0.00% <0.00%> (-100.00%)`	⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java	`0.00% <0.00%> (-96.16%)`	⬇️
...egistrycenter/context/ZookeeperWindowsContext.java	`0.00% <0.00%> (-81.82%)`	⬇️
...ize/hessian2/dubbo/Hessian2FactoryInitializer.java	`0.00% <0.00%> (-81.82%)`	⬇️
...istrycenter/processor/FindPidWindowsProcessor.java	`5.40% <0.00%> (-81.09%)`	⬇️
... and 454 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sconvent · 2023-01-10T21:37:54Z

@AlbumenJ It is best practice to have the .mvn/wrapper/maven-wrapper.jar checked in into the repo of the project. And it was updated using the recommended way (as stated in the PR with mvn wrapper:wrapper -Dmaven=3.8.7). That command alone did the updates in this PR. I believe sticking to the recommended setup is a good way unless there are good reasons against it.

AlbumenJ · 2023-01-11T00:14:56Z

It is best practice to have the .mvn/wrapper/maven-wrapper.jar checked in into the repo of the project. And it was updated using the recommended way (as stated in the PR with mvn wrapper:wrapper -Dmaven=3.8.7). That command alone did the updates in this PR. I believe sticking to the recommended setup is a good way unless there are good reasons against it.

@sconvent
According to the policy[1] from ASF, any project belongs to ASF should prevent to including any binary files (e.g. jar) in source release.
BTW, I found a maven wrapper mail thread[2] discussing it with ASF members. It is also explicitly mentioned in the discussion that no binaries can be included in the source code

[1] https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
[2] https://lists.apache.org/thread/rwzlx5l0046rcl4zz92m0q8p3mn1xc6r

sconvent · 2023-01-11T19:34:07Z

@AlbumenJ Ok, now I understand the reasoning much better. Thanks for the explanation!
I removed the jar and re-added it to the .gitignore file.
Tested it locally and the jar will be downloaded at compile-time.