-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Maven Wrapper to 3.8.7 #11260
Bump Maven Wrapper to 3.8.7 #11260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we download .mvn/wrapper/maven-wrapper.jar
in runtime instead of source provided?
Codecov Report
@@ Coverage Diff @@
## 3.2 #11260 +/- ##
============================================
- Coverage 69.54% 65.04% -4.51%
+ Complexity 132 14 -118
============================================
Files 1503 1479 -24
Lines 80071 61746 -18325
Branches 14133 9045 -5088
============================================
- Hits 55688 40161 -15527
+ Misses 19591 17384 -2207
+ Partials 4792 4201 -591
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@AlbumenJ It is best practice to have the |
@sconvent [1] https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist |
@AlbumenJ Ok, now I understand the reasoning much better. Thanks for the explanation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your contribution.
Kudos, SonarCloud Quality Gate passed! |
What is the purpose of the change
The used Maven version and Maven Wrapper version are out of date.
Brief changelog
All of these changes were made using the recommended way with the following command:
mvn wrapper:wrapper -Dmaven=3.8.7
Verifying this change
Just via CI
Checklist