Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dubbox core features from dangdang: #1001

Merged
merged 4 commits into from
Jan 2, 2018
Merged

merge dubbox core features from dangdang: #1001

merged 4 commits into from
Jan 2, 2018

Conversation

terrymanu
Copy link
Member

What is the purpose of the change

merge dubbox core features

Brief changelog

  1. rest protocol
  2. kryo & fst serialization
  3. embed tomcat

1. rest protocol
2. kryo & fst serialization
3. embed tomcat
@CLAassistant
Copy link

CLAassistant commented Dec 5, 2017

CLA assistant check
All committers have signed the CLA.

@chickenlj
Copy link
Contributor

We have been concerned about the awesome features in dubbox, thanks for making this contribution.
Are you an official partner of dubbox? Maybe we can issue an announcement separately, so both users of dubbo and dubbox can notice this change. We can continue to promote these features on the dubbo project.

@terrymanu
Copy link
Member Author

@chickenlj Hello chickenlj. Yes, I am dubbox's official owner from dangdang. Thanks for alibaba open source dubbo, it is really a wonderful project.
It is a good idea to issue an announcement separately after dubbo merge dubbox.

@zhangruhong
Copy link

zhangruhong commented Dec 6, 2017

火钳刘明(Leave a message/comment before it becomes a top/hot tweet.)

@chickenlj
Copy link
Contributor

We decide to merge this part after version 2.5.8, which will be in the next few days.

@linyongfu2013
Copy link

so it should be coming soon ? looking forward to it .

@lovepoem
Copy link
Member

#764

@kirbylynx
Copy link

Really looking forward for 2.5.8.
As far as I know, it would include two exciting features, REST/kryo/FST serialization, and spring boot starter support.

@fanlei1988
Copy link

真是个好消息,不过,我还是希望dubbo 同时也可以支持SpringMVC 的Rest实现, 因为我感觉dubbox 和swagger 兼容并不是很好,并且并不支持其他容器吧

@nmyphp
Copy link

nmyphp commented Dec 12, 2017

太好了!作为当当员工,之前一直使用dubbox,得知dubbo重新维护了,第一个问题就是dubbox是否会继续更新,这下好了。会一直关注

@zuohl
Copy link

zuohl commented Dec 17, 2017

怎么pr还不合并,,还是说准备自己实现一套..

# Conflicts:
#	dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ProtocolConfig.java
# Conflicts:
#	dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ProtocolConfig.java
@codecov-io
Copy link

Codecov Report

Merging #1001 into master will decrease coverage by 0.26%.
The diff coverage is 20.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1001      +/-   ##
==========================================
- Coverage   27.68%   27.42%   -0.27%     
==========================================
  Files         789      824      +35     
  Lines       41577    42297     +720     
  Branches     8476     8556      +80     
==========================================
+ Hits        11510    11598      +88     
- Misses      28021    28636     +615     
- Partials     2046     2063      +17
Impacted Files Coverage Δ
.../main/java/com/alibaba/dubbo/common/Constants.java 88.88% <ø> (ø) ⬆️
...dubbo/rpc/protocol/rest/support/LoggingFilter.java 0% <0%> (ø)
...a/dubbo/remoting/http/tomcat/TomcatHttpServer.java 0% <0%> (ø)
...java/com/alibaba/dubbo/rpc/ServiceClassHolder.java 0% <0%> (ø)
...libaba/dubbo/rpc/protocol/rest/UndertowServer.java 0% <0%> (ø)
...alibaba/dubbo/rpc/protocol/rest/SunHttpServer.java 0% <0%> (ø)
...common/serialize/support/fst/FstSerialization.java 0% <0%> (ø)
...a/dubbo/remoting/exchange/codec/ExchangeCodec.java 66.66% <0%> (-1.3%) ⬇️
...om/alibaba/dubbo/rpc/protocol/rest/TjwsServer.java 0% <0%> (ø)
...rc/main/java/com/alibaba/dubbo/rpc/RpcContext.java 27.04% <0%> (-1.07%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72cecba...6bea1d3. Read the comment docs.

@chickenlj chickenlj changed the base branch from master to 2.6 January 2, 2018 08:22
@chickenlj
Copy link
Contributor

I decide to merge this PR to the 2.6 branch first, and do some adjust, e.g, upgrade dependency version.

@chickenlj chickenlj merged commit ab8af67 into apache:2.6 Jan 2, 2018
@FredGoo
Copy link

FredGoo commented Jan 5, 2018

持续关注中

@chickenlj
Copy link
Contributor

The core features of this PR have been published in 2.6.0

@chickenlj chickenlj added this to the 2.6.0 milestone Jan 8, 2018
@Lovelcp
Copy link

Lovelcp commented Jan 8, 2018

赞赞赞

@leontius
Copy link

leontius commented Jan 9, 2018

关注中。

@PepperYan
Copy link

等了这么久终于合并了!

@zhenyajiang
Copy link

you should metion about what's the version of kyro and FST dependency. it cause the problem. Caused by: java.lang.NoClassDefFoundError: com/esotericsoftware/kryo/pool/KryoFactory.
anyway, tks a lot for dangdang and alibaba open source.

@superleo-cn
Copy link

我在kryo基础上还加入了twitter chill,支持Java的同时,还能比较完美的支持Scala,让Scala童鞋也能享受dubbo直接支持数据类型的快感,如何分享呢?

@luzhzhsoft
Copy link

有没有rest 的demo 或者相关的文档介绍呐?按照当当的demo 跑不起来。好像是kryo 版本的问题

@nmyphp
Copy link

nmyphp commented Apr 15, 2018

@luzhzhsoft可以参考一下这篇CSDN博客:https://blog.csdn.net/nmyphp/article/details/79174225

@lovepoem
Copy link
Member

我在kryo基础上还加入了twitter chill,支持Java的同时,还能比较完美的支持Scala,让Scala童鞋也能享受dubbo直接支持数据类型的快感,如何分享

@superleo-cn ,can you give your code repository?

@ldcsaa
Copy link

ldcsaa commented Feb 22, 2019

@lovepoem 现在的dubbo与当当的dubbox(2.8.4)应该是不兼容的吧?dubbox修改了dubbo的序列化协议。
\dubbo\rpc\protocol\dubbo\DubboCodec.java 对比:
image

@lovepoem
Copy link
Member

\dubbo\rpc\protocol\dubbo\DubboCodec.java 对比:
你用的什么协议? 如果是默认的hessian协议,还是支持的

rolandhe pushed a commit to rolandhe/dubbo that referenced this pull request Sep 9, 2019
1. rest protocol
2. kryo & fst serialization
3. embed tomcat
@zhangruhong
Copy link

zhangruhong commented Mar 20, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.