-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge dubbox core features from dangdang: #1001
Conversation
1. rest protocol 2. kryo & fst serialization 3. embed tomcat
We have been concerned about the awesome features in dubbox, thanks for making this contribution. |
@chickenlj Hello chickenlj. Yes, I am dubbox's official owner from dangdang. Thanks for alibaba open source dubbo, it is really a wonderful project. |
火钳刘明(Leave a message/comment before it becomes a top/hot tweet.) |
We decide to merge this part after version 2.5.8, which will be in the next few days. |
so it should be coming soon ? looking forward to it . |
Really looking forward for 2.5.8. |
真是个好消息,不过,我还是希望dubbo 同时也可以支持SpringMVC 的Rest实现, 因为我感觉dubbox 和swagger 兼容并不是很好,并且并不支持其他容器吧 |
太好了!作为当当员工,之前一直使用dubbox,得知dubbo重新维护了,第一个问题就是dubbox是否会继续更新,这下好了。会一直关注 |
怎么pr还不合并,,还是说准备自己实现一套.. |
# Conflicts: # dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ProtocolConfig.java
# Conflicts: # dubbo-config/dubbo-config-api/src/main/java/com/alibaba/dubbo/config/ProtocolConfig.java
Codecov Report
@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
- Coverage 27.68% 27.42% -0.27%
==========================================
Files 789 824 +35
Lines 41577 42297 +720
Branches 8476 8556 +80
==========================================
+ Hits 11510 11598 +88
- Misses 28021 28636 +615
- Partials 2046 2063 +17
Continue to review full report at Codecov.
|
I decide to merge this PR to the 2.6 branch first, and do some adjust, e.g, upgrade dependency version. |
持续关注中 |
The core features of this PR have been published in 2.6.0 |
赞赞赞 |
关注中。 |
等了这么久终于合并了! |
you should metion about what's the version of kyro and FST dependency. it cause the problem. Caused by: java.lang.NoClassDefFoundError: com/esotericsoftware/kryo/pool/KryoFactory. |
我在kryo基础上还加入了twitter chill,支持Java的同时,还能比较完美的支持Scala,让Scala童鞋也能享受dubbo直接支持数据类型的快感,如何分享呢? |
有没有rest 的demo 或者相关的文档介绍呐?按照当当的demo 跑不起来。好像是kryo 版本的问题 |
@superleo-cn ,can you give your code repository? |
@lovepoem 现在的dubbo与当当的dubbox(2.8.4)应该是不兼容的吧?dubbox修改了dubbo的序列化协议。 |
|
1. rest protocol 2. kryo & fst serialization 3. embed tomcat
这是我的自动回复邮件。
This is an automatic reply of the email system.
您好,你的邮件我己收到,我会尽快处理,谢谢!I have received your E-mail, and I will reply as soon as possible. Thank you!
|
What is the purpose of the change
merge dubbox core features
Brief changelog