Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](udf) Fix exception thrown when replayDropFunction #39805

Merged
merged 1 commit into from
Aug 23, 2024
Merged

[fix](udf) Fix exception thrown when replayDropFunction #39805

merged 1 commit into from
Aug 23, 2024

Conversation

gavinchou
Copy link
Contributor

@gavinchou gavinchou commented Aug 22, 2024 •
edited
Loading

This PR completes #25965 to fix uncaught runtime exception when calling org.apache.doris.catalog.GlobalFunctionMgr#replayDropFunction
img_v3_02e0_3889b1de-583e-48ba-8e7f-48e1d3ae799g

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@gavinchou
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 37699 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 18e5157b9704ed59b77ee17896a3f1d95ec57e28, data reload: false

------ Round 1 ----------------------------------
q1	17611	4914	4301	4301
q2	2017	179	183	179
q3	11806	930	1099	930
q4	10497	708	744	708
q5	7755	2822	2806	2806
q6	225	136	133	133
q7	992	597	599	597
q8	9316	2073	2074	2073
q9	7281	6553	6540	6540
q10	6991	2265	2203	2203
q11	454	238	242	238
q12	395	218	227	218
q13	17760	3017	2996	2996
q14	287	227	248	227
q15	525	476	488	476
q16	497	408	382	382
q17	987	686	765	686
q18	7412	6664	6862	6664
q19	1377	1065	1078	1065
q20	690	344	331	331
q21	4151	2920	3056	2920
q22	1141	1026	1029	1026
Total cold run time: 110167 ms
Total hot run time: 37699 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4374	4303	4252	4252
q2	380	266	276	266
q3	2912	2647	2624	2624
q4	1903	1668	1635	1635
q5	5568	5677	5707	5677
q6	243	140	138	138
q7	2223	1821	1813	1813
q8	3327	3395	3424	3395
q9	8826	8849	8877	8849
q10	3579	3408	3388	3388
q11	623	520	513	513
q12	833	647	695	647
q13	15862	3171	3255	3171
q14	316	282	288	282
q15	551	489	508	489
q16	536	440	442	440
q17	1849	1536	1526	1526
q18	8107	7869	7764	7764
q19	1758	1665	1495	1495
q20	2137	1909	1925	1909
q21	5755	5545	5512	5512
q22	1179	1039	1041	1039
Total cold run time: 72841 ms
Total hot run time: 56824 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191543 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 18e5157b9704ed59b77ee17896a3f1d95ec57e28, data reload: false

query1	1238	890	835	835
query2	6305	1859	1897	1859
query3	10725	4181	4141	4141
query4	60037	25761	23156	23156
query5	5536	505	490	490
query6	404	166	158	158
query7	5777	295	295	295
query8	302	213	210	210
query9	8857	2475	2482	2475
query10	479	272	259	259
query11	17732	15008	15271	15008
query12	172	101	105	101
query13	1551	404	388	388
query14	11010	7304	7344	7304
query15	230	173	175	173
query16	7532	486	466	466
query17	1101	544	582	544
query18	2065	299	313	299
query19	281	153	148	148
query20	121	113	107	107
query21	204	105	101	101
query22	4606	4359	4503	4359
query23	34409	33654	33502	33502
query24	5906	2806	2762	2762
query25	515	403	375	375
query26	679	155	153	153
query27	1803	280	275	275
query28	3643	2037	2019	2019
query29	675	400	405	400
query30	239	150	146	146
query31	942	766	755	755
query32	74	52	55	52
query33	442	286	281	281
query34	873	469	464	464
query35	829	715	722	715
query36	1038	944	959	944
query37	144	87	84	84
query38	3978	3821	3825	3821
query39	1476	1390	1406	1390
query40	196	121	121	121
query41	50	50	46	46
query42	124	106	97	97
query43	510	486	457	457
query44	1081	749	740	740
query45	198	165	169	165
query46	1110	739	715	715
query47	1855	1829	1825	1825
query48	368	289	305	289
query49	779	445	453	445
query50	831	430	412	412
query51	7273	7090	7138	7090
query52	103	86	89	86
query53	254	181	183	181
query54	561	466	461	461
query55	78	77	78	77
query56	288	274	271	271
query57	1196	1085	1057	1057
query58	236	229	235	229
query59	3042	2685	2669	2669
query60	300	278	291	278
query61	124	125	123	123
query62	750	616	653	616
query63	216	189	189	189
query64	3368	1735	1794	1735
query65	3204	3175	3145	3145
query66	656	340	334	334
query67	15523	15447	15155	15155
query68	3350	575	563	563
query69	390	275	275	275
query70	1197	1139	1141	1139
query71	348	278	288	278
query72	2747	2149	2058	2058
query73	715	315	316	315
query74	9536	8818	8773	8773
query75	3372	2639	2665	2639
query76	1415	998	970	970
query77	509	319	312	312
query78	9671	9030	8991	8991
query79	1049	534	528	528
query80	680	498	504	498
query81	453	225	228	225
query82	293	138	138	138
query83	170	150	152	150
query84	263	77	77	77
query85	670	292	319	292
query86	309	293	289	289
query87	4484	4326	4304	4304
query88	3126	2277	2282	2277
query89	387	291	283	283
query90	1949	201	198	198
query91	124	99	103	99
query92	59	51	57	51
query93	1086	525	532	525
query94	726	291	315	291
query95	360	272	265	265
query96	585	271	261	261
query97	3166	3016	3041	3016
query98	224	211	203	203
query99	1546	1265	1238	1238
Total cold run time: 303163 ms
Total hot run time: 191543 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.46 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 18e5157b9704ed59b77ee17896a3f1d95ec57e28, data reload: false

query1	0.04	0.05	0.04
query2	0.06	0.04	0.04
query3	0.23	0.04	0.05
query4	1.68	0.08	0.07
query5	0.50	0.48	0.49
query6	1.14	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.48
query10	0.54	0.54	0.53
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.58	0.58
query14	0.77	0.81	0.78
query15	0.88	0.82	0.82
query16	0.38	0.37	0.38
query17	1.06	1.00	1.06
query18	0.22	0.20	0.20
query19	1.92	1.73	1.75
query20	0.01	0.01	0.00
query21	15.38	0.66	0.65
query22	4.80	7.23	1.62
query23	18.34	1.30	1.21
query24	2.07	0.22	0.24
query25	0.15	0.09	0.08
query26	0.27	0.20	0.17
query27	0.08	0.08	0.08
query28	13.26	1.02	0.99
query29	12.63	3.37	3.35
query30	0.24	0.06	0.06
query31	3.16	0.43	0.40
query32	3.68	0.49	0.48
query33	3.07	3.02	3.08
query34	17.13	4.39	4.39
query35	4.48	4.51	4.56
query36	0.66	0.47	0.48
query37	0.20	0.15	0.16
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.15	0.13	0.14
query41	0.10	0.05	0.04
query42	0.06	0.05	0.05
query43	0.05	0.04	0.05
Total cold run time: 111.13 s
Total hot run time: 30.46 s

@gavinchou
Copy link
Contributor Author

run p0

@wm1581066 wm1581066 added usercase Important user case type label p0_c labels Aug 23, 2024
@morrySnow
Copy link
Contributor

replace screenshot with text then we could put it into commit msg

@morrySnow
Copy link
Contributor

why replay could meet drop non-exists udf?

dataroaring
dataroaring approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit a521488 into apache:master Aug 23, 2024
30 of 32 checks passed
dataroaring pushed a commit that referenced this pull request Aug 23, 2024
@gavinchou @dataroaring
[fix](udf) Fix exception thrown when replayDropFunction (#39805)
8e5c4d9 
This PR completes #25965 to fix uncaught runtime exception when calling
`org.apache.doris.catalog.GlobalFunctionMgr#replayDropFunction`

![img_v3_02e0_3889b1de-583e-48ba-8e7f-48e1d3ae799g](https://github.com/user-attachments/assets/b0dbfefb-16f3-4dbb-8a00-f4773978ba01)
@dataroaring dataroaring mentioned this pull request Aug 24, 2024
Merged
@zhangstar333 zhangstar333 mentioned this pull request Sep 25, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangstar333 zhangstar333 zhangstar333 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.2-merged p0_c reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gavinchou @doris-robot @morrySnow @zhangstar333 @dataroaring @yiguolei @wm1581066